foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-25 15:29:32 -05:00
Code Issues Packages 1 Wiki Activity
denoland-deno/tests/specs/test/doc_failure/main.out

61 lines
1.5 KiB
Text
Raw Normal View History

feat(cli): evaluate code snippets in JSDoc and markdown (#25220) This commit lets `deno test --doc` command actually evaluate code snippets in JSDoc and markdown files. ## How it works 1. Extract code snippets from JSDoc or code fences 2. Convert them into pseudo files by wrapping them in `Deno.test(...)` 3. Register the pseudo files as in-memory files 4. Run type-check and evaluation We apply some magic at the step 2 - let's say we have the following file named `mod.ts` as an input: ````ts /** * ```ts * import { assertEquals } from "jsr:@std/assert/equals"; * * assertEquals(add(1, 2), 3); * ``` */ export function add(a: number, b: number) { return a + b; } ```` This is virtually transformed into: ```ts import { assertEquals } from "jsr:@std/assert/equals"; import { add } from "files:///path/to/mod.ts"; Deno.test("mod.ts$2-7.ts", async () => { assertEquals(add(1, 2), 3); }); ``` Note that a new import statement is inserted here to make `add` function available. In a nutshell, all items exported from `mod.ts` become available in the generated pseudo file with this automatic import insertion. The intention behind this design is that, from library user's standpoint, it should be very obvious that this `add` function is what this example code is attached to. Also, if there is an explicit import statement like `import { add } from "./mod.ts"`, this import path `./mod.ts` is not helpful for doc readers because they will need to import it in a different way. The automatic import insertion has some edge cases, in particular where there is a local variable in a snippet with the same name as one of the exported items. This case is addressed by employing swc's scope analysis (see test cases for more details). ## "type-checking only" mode stays around This change will likely impact a lot of existing doc tests in the ecosystem because some doc tests rely on the fact that they are not evaluated - some cause side effects if executed, some throw errors at runtime although they do pass the type check, etc. To help those tests gradually transition to the ones runnable with the new `deno test --doc`, we will keep providing the ability to run type-checking only via `deno check --doc`. Additionally there is a `--doc-only` option added to the `check` subcommand too, which is useful when you want to type-check on code snippets in markdown files, as normal `deno check` command doesn't accept markdown. ## Demo https://github.com/user-attachments/assets/47e9af73-d16e-472d-b09e-1853b9e8f5ce --- Closes #4716
2024-09-18 00:35:48 -04:00
Check [WILDCARD]/main.ts
Check [WILDCARD]/main.ts$2-9.ts
Check [WILDCARD]/main.ts$13-18.ts
Check [WILDCARD]/main.ts$24-29.ts
running 0 tests from ./main.ts
running 1 test from ./main.ts$2-9.ts
[WILDCARD]/main.ts$2-9.ts ... FAILED ([WILDCARD]ms)
running 1 test from ./main.ts$13-18.ts
[WILDCARD]/main.ts$13-18.ts ... FAILED ([WILDCARD]ms)
running 1 test from ./main.ts$24-29.ts
[WILDCARD]/main.ts$24-29.ts ... FAILED ([WILDCARD]ms)
ERRORS
[WILDCARD]/main.ts$13-18.ts => ./main.ts$13-18.ts:3:6
error: AssertionError: Values are not equal.
[Diff] Actual / Expected
- 3
+ 4
throw new AssertionError(message);
^
at assertEquals ([WILDCARD]/std/assert/equals.ts:[WILDCARD])
at [WILDCARD]/main.ts$13-18.ts:4:5
[WILDCARD]/main.ts$2-9.ts => ./main.ts$2-9.ts:3:6
error: AssertionError: Expected actual: "2.5e+0" to be close to "2": delta "5e-1" is greater than "2e-7".
throw new AssertionError(
^
at assertAlmostEquals ([WILDCARD]/std/assert/almost_equals.ts:[WILDCARD])
at [WILDCARD]/main.ts$2-9.ts:6:5
[WILDCARD]/main.ts$24-29.ts => ./main.ts$24-29.ts:3:6
error: AssertionError: Values are not equal.
[Diff] Actual / Expected
- 4
+ 3
throw new AssertionError(message);
^
at assertEquals ([WILDCARD]/std/assert/equals.ts:[WILDCARD])
at [WILDCARD]/main.ts$24-29.ts:4:5
FAILURES
[WILDCARD]/main.ts$13-18.ts => ./main.ts$13-18.ts:3:6
[WILDCARD]/main.ts$2-9.ts => ./main.ts$2-9.ts:3:6
[WILDCARD]/main.ts$24-29.ts => ./main.ts$24-29.ts:3:6
FAILED | 0 passed | 3 failed ([WILDCARD]ms)
error: Test failed
Copy permalink