foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-21 15:04:11 -05:00
Code Issues Packages 1 Wiki Activity

chore(cli/tests): move macos_shared_libraries test to macos_test.rs (#18268)

Browse source 
As per review comment in original PR:
https://github.com/denoland/deno/pull/18244#issuecomment-1473769606
This commit is contained in:
Divy Srivastava 2023-03-18 21:08:51 +05:30 committed by GitHub
parent d11e89127d
commit 00f4c0df97
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 42 additions and 37 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

40
cli/tests/integration/macos_tests.rs Normal file
View file

@ -0,0 +1,40 @@
// Copyright 2018-2023 the Deno authors. All rights reserved. MIT license.
#[cfg(target_os = "macos")]
#[test]
// https://github.com/denoland/deno/issues/18243
// This test is to prevent inadvertently linking to more shared system libraries that usually
// increases dyld startup time.
fn macos_shared_libraries() {
use test_util as util;
// target/release/deno:
// /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation (compatibility version 150.0.0, current version 1953.255.0)
// /System/Library/Frameworks/CoreServices.framework/Versions/A/CoreServices (compatibility version 1.0.0, current version 1228.0.0)
// /System/Library/Frameworks/Security.framework/Versions/A/Security (compatibility version 1.0.0, current version 60420.60.24)
// /usr/lib/libiconv.2.dylib (compatibility version 7.0.0, current version 7.0.0)
// /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1319.0.0)
const EXPECTED: [&str; 5] =
["/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation",
"/System/Library/Frameworks/CoreServices.framework/Versions/A/CoreServices",
"/System/Library/Frameworks/Security.framework/Versions/A/Security",
"/usr/lib/libiconv.2.dylib",
"/usr/lib/libSystem.B.dylib"];
let otool = std::process::Command::new("otool")
.arg("-L")
.arg(util::deno_exe_path())
.output()
.expect("Failed to execute otool");
let output = std::str::from_utf8(&otool.stdout).unwrap();
// Ensure that the output contains only the expected shared libraries.
for line in output.lines().skip(1) {
let path = line.split_whitespace().next().unwrap();
assert!(
EXPECTED.contains(&path),
"Unexpected shared library: {}",
path
);
}
}

39
cli/tests/integration/mod.rs
View file

@ -85,43 +85,6 @@ macro_rules! command_step(
} }
); );
#[cfg(target_os = "macos")]
#[test]
// https://github.com/denoland/deno/issues/18243
fn macos_shared_libraries() {
use test_util as util;
// target/release/deno:
// /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation (compatibility version 150.0.0, current version 1953.255.0)
// /System/Library/Frameworks/CoreServices.framework/Versions/A/CoreServices (compatibility version 1.0.0, current version 1228.0.0)
// /System/Library/Frameworks/Security.framework/Versions/A/Security (compatibility version 1.0.0, current version 60420.60.24)
// /usr/lib/libiconv.2.dylib (compatibility version 7.0.0, current version 7.0.0)
// /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1319.0.0)
const EXPECTED: [&str; 5] =
["/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation",
"/System/Library/Frameworks/CoreServices.framework/Versions/A/CoreServices",
"/System/Library/Frameworks/Security.framework/Versions/A/Security",
"/usr/lib/libiconv.2.dylib",
"/usr/lib/libSystem.B.dylib"];
let otool = std::process::Command::new("otool")
.arg("-L")
.arg(util::deno_exe_path())
.output()
.expect("Failed to execute otool");
let output = std::str::from_utf8(&otool.stdout).unwrap();
// Ensure that the output contains only the expected shared libraries.
for line in output.lines().skip(1) {
let path = line.split_whitespace().next().unwrap();
assert!(
EXPECTED.contains(&path),
"Unexpected shared library: {}",
path
);
}
}
// These files have `_tests.rs` suffix to make it easier to tell which file is // These files have `_tests.rs` suffix to make it easier to tell which file is
// the test (ex. `lint_tests.rs`) and which is the implementation (ex. `lint.rs`) // the test (ex. `lint_tests.rs`) and which is the implementation (ex. `lint.rs`)
// when both are open, especially for two tabs in VS Code // when both are open, especially for two tabs in VS Code
@ -162,6 +125,8 @@ mod js_unit_tests;
mod lint; mod lint;
#[path = "lsp_tests.rs"] #[path = "lsp_tests.rs"]
mod lsp; mod lsp;
#[path = "macos_tests.rs"]
mod macos;
#[path = "node_compat_tests.rs"] #[path = "node_compat_tests.rs"]
mod node_compat_tests; mod node_compat_tests;
#[path = "node_unit_tests.rs"] #[path = "node_unit_tests.rs"]