foster/denoland-deno
0
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-10-29 08:58:01 -04:00
Code Issues Wiki Activity

fix(std/http): parsing of HTTP version header (#8902)

Browse source
This commit is contained in:
Noxazer 2020-12-31 00:17:41 +01:00 committed by GitHub
parent e568ddf996
commit 0163cedd80
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
std/http/_io.ts
View file

@ -346,7 +346,7 @@ export async function readRequest(
req.conn = conn;
req.r = bufr;
[req.method, req.url, req.proto] = firstLine.split(" ", 3);
[req.protoMinor, req.protoMajor] = parseHTTPVersion(req.proto);
[req.protoMajor, req.protoMinor] = parseHTTPVersion(req.proto);
req.headers = headers;
fixLength(req);
return req;

11
std/http/_io_test.ts
View file

@ -407,6 +407,11 @@ Deno.test("testReadRequestError", async function (): Promise<void> {
in: "GET / HTTP/1.1\r\nheader:foo\r\n",
err: Deno.errors.UnexpectedEof,
},
{
in: "POST / HTTP/1.0\r\n\r\n",
headers: [],
version: true,
},
{ in: "", eof: true },
{
in: "HEAD / HTTP/1.1\r\nContent-Length:4\r\n\r\n",
@ -472,6 +477,12 @@ Deno.test("testReadRequestError", async function (): Promise<void> {
assert(err instanceof (test.err as typeof Deno.errors.UnexpectedEof));
} else {
assert(req instanceof ServerRequest);
if (test.version) {
// return value order of parseHTTPVersion() function have to match with [req.protoMajor, req.protoMinor];
const version = parseHTTPVersion(test.in.split(" ", 3)[2]);
assertEquals(req.protoMajor, version[0]);
assertEquals(req.protoMinor, version[1]);
}
assert(test.headers);
assertEquals(err, undefined);
assertNotEquals(req, null);