foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-28 16:20:57 -05:00
Code Issues Packages 1 Wiki Activity

fix(ext/node): process.uptime works without this (#23786)

Browse source 
Fixes https://github.com/denoland/deno/issues/23761

Co-authored-by: Satya Rohith <me@satyarohith.com>
This commit is contained in:
Bartek Iwańczuk 2024-05-13 00:38:22 +01:00 committed by GitHub
parent 2b62a5b814
commit 03a76f33ad
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
ext/node/polyfills/process.ts
View file

@ -668,14 +668,9 @@ class Process extends EventEmitter {
execPath = path;
}
setStartTime(t: number) {
this.#startTime = t;
}
#startTime = 0;
/** https://nodejs.org/api/process.html#processuptime */
uptime() {
return (Date.now() - this.#startTime) / 1000;
return Number((performance.now() / 1000).toFixed(9));
}
#allowedFlags = buildAllowedFlags();
@ -887,16 +882,12 @@ internals.__bootstrapNodeProcess = function (
);
}
process.setStartTime(Date.now());
arch = arch_();
platform = isWindows ? "win32" : Deno.build.os;
pid = Deno.pid;
initializeDebugEnv(nodeDebug);
// @ts-ignore Remove setStartTime and #startTime is not modifiable
delete process.setStartTime;
delete internals.__bootstrapNodeProcess;
} else {
// Warmup, assuming stdin/stdout/stderr are all terminals

9
tests/unit_node/process_test.ts
View file

@ -1083,3 +1083,12 @@ Deno.test({
process.setSourceMapsEnabled(true); // noop
},
});
// Regression test for https://github.com/denoland/deno/issues/23761
Deno.test({
name: "process.uptime without this",
fn() {
const v = (0, process.uptime)();
assert(v >= 0);
},
});