foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-28 16:20:57 -05:00
Code Issues Packages 1 Wiki Activity

fix(cli): deno upgrade file permission (#18427)

Browse source
This commit is contained in:
滑威 2023-03-26 17:19:12 +08:00 committed by GitHub
parent 4d09b0c294
commit 0742ea1170
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
cli/tools/upgrade.rs
View file

@ -265,13 +265,15 @@ pub async fn upgrade(
) -> Result<(), AnyError> { ) -> Result<(), AnyError> {
let ps = ProcState::build(flags).await?; let ps = ProcState::build(flags).await?;
let current_exe_path = std::env::current_exe()?; let current_exe_path = std::env::current_exe()?;
let metadata = fs::metadata(&current_exe_path)?; let output_exe_path =
upgrade_flags.output.as_ref().unwrap_or(&current_exe_path);
let metadata = fs::metadata(output_exe_path)?;
let permissions = metadata.permissions(); let permissions = metadata.permissions();
if permissions.readonly() { if permissions.readonly() {
bail!( bail!(
"You do not have write permission to {}", "You do not have write permission to {}",
current_exe_path.display() output_exe_path.display()
); );
} }
#[cfg(unix)] #[cfg(unix)]
@ -282,7 +284,7 @@ pub async fn upgrade(
"You don't have write permission to {} because it's owned by root.\n", "You don't have write permission to {} because it's owned by root.\n",
"Consider updating deno through your package manager if its installed from it.\n", "Consider updating deno through your package manager if its installed from it.\n",
"Otherwise run `deno upgrade` as root.", "Otherwise run `deno upgrade` as root.",
), current_exe_path.display()); ), output_exe_path.display());
} }
let client = &ps.http_client; let client = &ps.http_client;