diff --git a/cli/tests/node_compat/test/parallel/test-os.js b/cli/tests/node_compat/test/parallel/test-os.js index 09d97222c5..d8425d0d52 100644 --- a/cli/tests/node_compat/test/parallel/test-os.js +++ b/cli/tests/node_compat/test/parallel/test-os.js @@ -216,7 +216,6 @@ if (common.isWindows && process.env.USERPROFILE) { process.env.HOME = home; } -/* TODO(kt3k): Enable this test const pwd = os.userInfo(); is.object(pwd); const pwdBuf = os.userInfo({ encoding: 'buffer' }); @@ -245,7 +244,7 @@ is.string(pwd.username); assert.ok(pwd.homedir.includes(path.sep)); assert.strictEqual(pwd.username, pwdBuf.username.toString('utf8')); assert.strictEqual(pwd.homedir, pwdBuf.homedir.toString('utf8')); -*/ + assert.strictEqual(`${os.hostname}`, os.hostname()); assert.strictEqual(`${os.homedir}`, os.homedir()); diff --git a/ext/node/polyfills/os.ts b/ext/node/polyfills/os.ts index a874c942cb..c552b5a0ad 100644 --- a/ext/node/polyfills/os.ts +++ b/ext/node/polyfills/os.ts @@ -320,8 +320,8 @@ export function uptime(): number { export function userInfo( options: UserInfoOptions = { encoding: "utf-8" }, ): UserInfo { - const uid = Deno.uid(); - const gid = Deno.gid(); + let uid = Deno.uid(); + let gid = Deno.gid(); if (isWindows) { uid = -1;