diff --git a/ext/node/polyfills/README.md b/ext/node/polyfills/README.md index 11de64bd99..748c53daa6 100644 --- a/ext/node/polyfills/README.md +++ b/ext/node/polyfills/README.md @@ -226,4 +226,4 @@ It's not as clean, but prevents the callback being called twice. Node compatibility can be measured by how many native Node tests pass. If you'd like to know what you can work on, check out the list of Node tests remaining -[here](_tools/TODO.md). +[here](_tools/node_compat/TODO.md). diff --git a/tools/node_compat/README.md b/tools/node_compat/README.md index 08fcc077b4..c422a1d0e3 100644 --- a/tools/node_compat/README.md +++ b/tools/node_compat/README.md @@ -11,7 +11,7 @@ Node.js compat testing in Deno repository. - This script sets up the Node.js compat tests. - `//tools/node_comapt/versions/` - Node.js source tarballs and extracted test cases are stored here. -- `//cli/tests/node_compat/config.json` +- `//cli/tests/node_compat/config.jsonc` - This json file stores the settings about which Node.js compat test to run with Deno. - `//cli/tests/node_compat/test` @@ -19,21 +19,22 @@ Node.js compat testing in Deno repository. ## Steps to add new test cases from Node.js test cases -1. Update `tests` property of `//cli/tests/node_compat/config.json`. For +1. Update `tests` property of `//cli/tests/node_compat/config.jsonc`. For example, if you want to add `test/paralles/test-foo.js` from Node.js test cases, then add `test-foo.js` entry in `tests.parallel` array property in - `config.json` + `config.jsonc` 1. Run `./tools/node_compat/setup.ts` The above command copies the updated items from Node.js tarball to the Deno source tree. Ideally Deno should pass the Node.js compat tests without modification, but if -you need to modify it, then add that item in `ignore` perperty of `config.json`. -Then `setup.ts` doesn't overwrite the modified Node.js test cases anymore. +you need to modify it, then add that item in `ignore` perperty of +`config.jsonc`. Then `setup.ts` doesn't overwrite the modified Node.js test +cases anymore. If the test needs to be ignored in particular platform, then add them in -`${platform}Ignore` property of `config.json` +`${platform}Ignore` property of `config.jsonc` ## Run Node.js test cases