foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-22 15:24:46 -05:00
Code Issues Packages 1 Wiki Activity

fix(repl): don't panic on undefined exception (#18888)

Browse source 
Fixes regression from #18878 where `Promise.reject()`,
`Promise.reject(undefined)` and `reportError(undefined)` panic in the
REPL.
Fixes `throw undefined` printing `Uncaught Unknown exception` instead of
`Uncaught undefined`.
This commit is contained in:
Nayeem Rahman 2023-04-28 14:21:55 +01:00 committed by GitHub
parent 84b921555f
commit 0b296c6378
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 16 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
cli/tests/integration/repl_tests.rs
View file

@ -824,6 +824,20 @@ fn repl_report_error() {
});
}
#[test]
fn repl_error_undefined() {
util::with_pty(&["repl"], |mut console| {
console.write_line(r#"throw undefined;"#);
console.expect("Uncaught undefined");
console.write_line(r#"Promise.reject();"#);
console.expect("Promise { <rejected> undefined }");
console.expect("Uncaught (in promise) undefined");
console.write_line(r#"reportError(undefined);"#);
console.expect("undefined");
console.expect("Uncaught undefined");
});
}
#[test]
fn pty_aggregate_error() {
util::with_pty(&["repl"], |mut console| {

2
cli/tools/repl/mod.rs
View file

@ -70,7 +70,7 @@ async fn read_line_and_poll(
let exception_details = params.get("exceptionDetails").unwrap().as_object().unwrap();
let text = exception_details.get("text").unwrap().as_str().unwrap();
let exception = exception_details.get("exception").unwrap().as_object().unwrap();
let description = exception.get("description").unwrap().as_str().unwrap();
let description = exception.get("description").and_then(|d| d.as_str()).unwrap_or("undefined");
println!("{text} {description}");
}
}

2
cli/tools/repl/session.rs
View file

@ -260,7 +260,7 @@ impl ReplSession {
let description = match exception_details.exception {
Some(exception) => exception
.description
.unwrap_or_else(|| "Unknown exception".to_string()),
.unwrap_or_else(|| "undefined".to_string()),
None => "Unknown exception".to_string(),
};
EvaluationOutput::Error(format!(