foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-22 15:06:54 -05:00
Code Issues Packages 1 Wiki Activity

chore: introduce rust_treat_warnings_as_errors build arg

Browse source
This commit is contained in:
Yoshiya Hinosawa 2018-08-13 17:04:18 +09:00 committed by Ryan Dahl
parent f46c271afc
commit 0ce7b6e870
2 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
.gn
View file

@ -30,6 +30,7 @@ default_args = {
is_component_build = false is_component_build = false
symbol_level = 1 symbol_level = 1
treat_warnings_as_errors = false treat_warnings_as_errors = false
rust_treat_warnings_as_errors = false
# https://cs.chromium.org/chromium/src/docs/ccache_mac.md # https://cs.chromium.org/chromium/src/docs/ccache_mac.md
clang_use_chrome_plugins = false clang_use_chrome_plugins = false

9
build_extra/rust/rust.gni
View file

@ -1,6 +1,9 @@
declare_args() { declare_args() {
# Absolute path of rust build files. # Absolute path of rust build files.
rust_build = "//build_extra/rust/" rust_build = "//build_extra/rust/"
# treat the warnings in rust files as errors
rust_treat_warnings_as_errors = true
} }
if (is_win) { if (is_win) {
@ -67,14 +70,16 @@ template("run_rustc") {
] ]
script = "//tools/run_rustc.py" script = "//tools/run_rustc.py"
# TODO: We want to apply "-Dwarnings" only when treat_warnings_as_errors is not false
# https://github.com/denoland/deno/pull/379
args = [ args = [
rebase_path(source_root, root_build_dir), rebase_path(source_root, root_build_dir),
"--crate-name=$crate_name", "--crate-name=$crate_name",
"--crate-type=$crate_type", "--crate-type=$crate_type",
] ]
if (rust_treat_warnings_as_errors) {
args += [ "-Dwarnings" ]
}
if (!is_win) { if (!is_win) {
args += [ "--color=always" ] args += [ "--color=always" ]
} }