foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-28 16:20:57 -05:00
Code Issues Packages 1 Wiki Activity

test: run js_unit_tests with --unstable-* flags (#25394)

Browse source
This commit is contained in:
Bartek Iwańczuk 2024-09-04 13:21:02 +01:00 committed by GitHub
parent 5ee671311a
commit 0e0a5c24ea
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 44 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
runtime/js/99_main.js
View file

@ -722,9 +722,6 @@ function bootstrapMainRuntime(runtimeOptions, warmup = false) {
target, target,
); );
// TODO(bartlomieju): deprecate --unstable
if (unstableFlag) {
ObjectAssign(finalDenoNs, denoNsUnstable);
// TODO(bartlomieju): this is not ideal, but because we use `ObjectAssign` // TODO(bartlomieju): this is not ideal, but because we use `ObjectAssign`
// above any properties that are defined elsewhere using `Object.defineProperty` // above any properties that are defined elsewhere using `Object.defineProperty`
// are lost. // are lost.
@ -742,6 +739,10 @@ function bootstrapMainRuntime(runtimeOptions, warmup = false) {
jupyterNs = val; jupyterNs = val;
}, },
}); });
// TODO(bartlomieju): deprecate --unstable
if (unstableFlag) {
ObjectAssign(finalDenoNs, denoNsUnstable);
} else { } else {
for (let i = 0; i <= unstableFeatures.length; i++) { for (let i = 0; i <= unstableFeatures.length; i++) {
const id = unstableFeatures[i]; const id = unstableFeatures[i];

2
runtime/lib.rs
View file

@ -83,7 +83,7 @@ pub static UNSTABLE_GRANULAR_FLAGS: &[UnstableGranularFlag] = &[
UnstableGranularFlag { UnstableGranularFlag {
name: ops::http::UNSTABLE_FEATURE_NAME, name: ops::http::UNSTABLE_FEATURE_NAME,
help_text: "Enable unstable HTTP APIs", help_text: "Enable unstable HTTP APIs",
show_in_help: false, show_in_help: true,
id: 5, id: 5,
}, },
UnstableGranularFlag { UnstableGranularFlag {

32
tests/integration/js_unit_tests.rs
View file

@ -116,22 +116,40 @@ util::unit_test_factory!(
fn js_unit_test(test: String) { fn js_unit_test(test: String) {
let _g = util::http_server(); let _g = util::http_server();
let deno = util::deno_cmd() let mut deno = util::deno_cmd()
.current_dir(util::root_path()) .current_dir(util::root_path())
.arg("test") .arg("test")
.arg("--config") .arg("--config")
.arg(util::deno_config_path()) .arg(util::deno_config_path())
.arg("--no-lock") .arg("--no-lock")
.arg("--unstable") // TODO(bartlomieju): would be better if we could apply this unstable
// flag to particular files, but there's many of them that rely on unstable
// net APIs (`reusePort` in `listen` and `listenTls`; `listenDatagram`, `createHttpClient`)
.arg("--unstable-net")
.arg("--unstable-http")
.arg("--location=http://127.0.0.1:4545/") .arg("--location=http://127.0.0.1:4545/")
.arg("--no-prompt"); .arg("--no-prompt");
if test == "broadcast_channel_test" {
deno = deno.arg("--unstable-broadcast-channel");
}
if test == "cron_test" {
deno = deno.arg("--unstable-cron");
}
if test.contains("kv_") {
deno = deno.arg("--unstable-kv");
}
if test == "worker_permissions_test" || test == "worker_test" {
deno = deno.arg("--unstable-worker-options");
}
// TODO(mmastrac): it would be better to just load a test CA for all tests // TODO(mmastrac): it would be better to just load a test CA for all tests
let deno = if test == "websocket_test" || test == "tls_sni_test" { if test == "websocket_test" || test == "tls_sni_test" {
deno.arg("--unsafely-ignore-certificate-errors") deno = deno.arg("--unsafely-ignore-certificate-errors");
} else { }
deno
};
let mut deno = deno let mut deno = deno
.arg("-A") .arg("-A")