foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-21 15:04:11 -05:00
Code Issues Packages 1 Wiki Activity

fix(check): expose more globals from @types/node (#26603)

Browse source 
Extracted out of https://github.com/denoland/deno/pull/26558

Closes https://github.com/denoland/deno/issues/26578
This commit is contained in:
David Sherret 2024-10-28 17:43:41 -04:00 committed by GitHub
parent 4e38fbd0a3
commit 0e641632c3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 13 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
cli/tsc/99_main_compiler.js
View file

@ -1337,18 +1337,12 @@ delete Object.prototype.__proto__;
"console",
"Console",
"ErrorConstructor",
"exports",
"gc",
"Global",
"ImportMeta",
"localStorage",
"module",
"NodeModule",
"NodeRequire",
"process",
"queueMicrotask",
"RequestInit",
"require",
"ResponseInit",
"sessionStorage",
"setImmediate",

4
tests/specs/npm/compare_globals/__test__.jsonc
View file

@ -1,4 +1,4 @@
{
"args": "run --allow-read --check=all compare_globals/main.ts",
"output": "compare_globals/main.out"
"args": "run --allow-read --check=all main.ts",
"output": "main.out"
}

3
tests/specs/npm/compare_globals/compare_globals/main.out → tests/specs/npm/compare_globals/main.out
View file

@ -8,10 +8,11 @@ Download http://localhost:4260/@denotest/globals/1.0.0.tgz
Download http://localhost:4260/@types/node/node-22.5.4.tgz
Download http://localhost:4260/undici-types/undici-types-6.19.8.tgz
[UNORDERED_END]
Check file:///[WILDCARD]/compare_globals/main.ts
Check file:///[WILDCARD]/main.ts
true
true
[]
process equals process true
setTimeout 1 false
setTimeout 2 function
setTimeout 3 function

11
tests/specs/npm/compare_globals/compare_globals/main.ts → tests/specs/npm/compare_globals/main.ts
View file

@ -5,10 +5,17 @@ console.log(globals.global === globals.globalThis);
// @ts-expect-error even though these are the same object, they have different types
console.log(globals.globalThis === globalThis);
console.log(globals.process.execArgv);
console.log("process equals process", process === globals.process);
type AssertTrue<T extends true> = never;
type _TestNoProcessGlobal = AssertTrue<
typeof globalThis extends { process: any } ? false : true
type _TestHasProcessGlobal = AssertTrue<
typeof globalThis extends { process: any } ? true : false
>;
type _TestProcessGlobalVersion = AssertTrue<
typeof process.versions.node extends string ? true : false
>;
type _TestNoBufferGlogal = AssertTrue<
typeof globalThis extends { Buffer: any } ? false : true
>;
type _TestHasNodeJsGlobal = NodeJS.Architecture;