BREAKING(fs): remove Deno.FsWatcher.prototype.rid (#25444)

Towards #22079

cli/tsc/dts/lib.deno.ns.d.ts

@@ -3849,14 +3849,6 @@ declare namespace Deno {
    * @category File System
    */
   export interface FsWatcher extends AsyncIterable<FsEvent>, Disposable {
-    /**
-     * The resource id.
-     *
-     * @deprecated This will be removed in Deno 2.0. See the
-     * {@link https://docs.deno.com/runtime/manual/advanced/migrate_deprecations | Deno 1.x to 2.x Migration Guide}
-     * for migration instructions.
-     */
-    readonly rid: number;
     /** Stops watching the file system and closes the watcher resource. */
     close(): void;
     /**

runtime/js/40_fs_events.js

@@ -31,15 +31,6 @@ class FsWatcher {
     this.#rid = op_fs_events_open({ recursive, paths });
   }
 
-  get rid() {
-    internals.warnOnDeprecatedApi(
-      "Deno.FsWatcher.rid",
-      new Error().stack,
-      "Use `Deno.FsWatcher` instance methods instead.",
-    );
-    return this.#rid;
-  }
-
   unref() {
     core.unrefOpPromise(this.#promise);
   }

tests/specs/future/runtime_api/main.js

@@ -53,10 +53,6 @@ console.log("Deno.TlsConn.prototype.rid is", tlsConn.rid);
 
 tlsConn.close();
 
-const watcher = Deno.watchFs(".");
-console.log("Deno.FsWatcher.prototype.rid is", watcher.rid);
-watcher.close();
-
 try {
   new Deno.FsFile(0);
 } catch (error) {

tests/specs/future/runtime_api/main.out

@@ -10,7 +10,6 @@ Deno.Conn.prototype.rid is undefined
 Deno.UnixConn.prototype.rid is undefined
 Deno.TlsListener.prototype.rid is undefined
 Deno.TlsConn.prototype.rid is undefined
-Deno.FsWatcher.prototype.rid is undefined
 Deno.FsFile constructor is illegal
 Deno.ConnectTlsOptions.(certFile|keyFile) do nothing
 Deno.ConnectTlsOptions.(certChain|privateKey) do nothing