foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-21 15:04:11 -05:00
Code Issues Packages 1 Wiki Activity

BREAKING(fs): remove Deno.FsWatcher.prototype.rid (#25444)

Browse source 
Towards #22079
This commit is contained in:
Asher Gomez 2024-09-05 16:23:28 +10:00 committed by GitHub
parent 713ed065e7
commit 105c2e336a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 0 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
cli/tsc/dts/lib.deno.ns.d.ts vendored
View file

@ -3849,14 +3849,6 @@ declare namespace Deno {
* @category File System * @category File System
*/ */
export interface FsWatcher extends AsyncIterable<FsEvent>, Disposable { export interface FsWatcher extends AsyncIterable<FsEvent>, Disposable {
/**
* The resource id.
*
* @deprecated This will be removed in Deno 2.0. See the
* {@link https://docs.deno.com/runtime/manual/advanced/migrate_deprecations | Deno 1.x to 2.x Migration Guide}
* for migration instructions.
*/
readonly rid: number;
/** Stops watching the file system and closes the watcher resource. */ /** Stops watching the file system and closes the watcher resource. */
close(): void; close(): void;
/** /**

9
runtime/js/40_fs_events.js
View file

@ -31,15 +31,6 @@ class FsWatcher {
this.#rid = op_fs_events_open({ recursive, paths }); this.#rid = op_fs_events_open({ recursive, paths });
} }
get rid() {
internals.warnOnDeprecatedApi(
"Deno.FsWatcher.rid",
new Error().stack,
"Use `Deno.FsWatcher` instance methods instead.",
);
return this.#rid;
}
unref() { unref() {
core.unrefOpPromise(this.#promise); core.unrefOpPromise(this.#promise);
} }

4
tests/specs/future/runtime_api/main.js
View file

@ -53,10 +53,6 @@ console.log("Deno.TlsConn.prototype.rid is", tlsConn.rid);
tlsConn.close(); tlsConn.close();
const watcher = Deno.watchFs(".");
console.log("Deno.FsWatcher.prototype.rid is", watcher.rid);
watcher.close();
try { try {
new Deno.FsFile(0); new Deno.FsFile(0);
} catch (error) { } catch (error) {

1
tests/specs/future/runtime_api/main.out
View file

@ -10,7 +10,6 @@ Deno.Conn.prototype.rid is undefined
Deno.UnixConn.prototype.rid is undefined Deno.UnixConn.prototype.rid is undefined
Deno.TlsListener.prototype.rid is undefined Deno.TlsListener.prototype.rid is undefined
Deno.TlsConn.prototype.rid is undefined Deno.TlsConn.prototype.rid is undefined
Deno.FsWatcher.prototype.rid is undefined
Deno.FsFile constructor is illegal Deno.FsFile constructor is illegal
Deno.ConnectTlsOptions.(certFile|keyFile) do nothing Deno.ConnectTlsOptions.(certFile|keyFile) do nothing
Deno.ConnectTlsOptions.(certChain|privateKey) do nothing Deno.ConnectTlsOptions.(certChain|privateKey) do nothing