foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-21 15:04:11 -05:00
Code Issues Packages 1 Wiki Activity

feat(ext/url): URLSearchParams two-argument delete() and has() (#19654)

Browse source
This commit is contained in:
Lino Le Van 2023-07-02 08:26:48 -07:00 committed by GitHub
parent d8e8e60f9f
commit 17ddf2f97c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 31 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
ext/url/00_url.js
View file

@ -169,19 +169,31 @@ class URLSearchParams {
/**
* @param {string} name
* @param {string} [value]
*/
delete(name) {
delete(name, value = undefined) {
webidl.assertBranded(this, URLSearchParamsPrototype);
const prefix = "Failed to execute 'append' on 'URLSearchParams'";
webidl.requiredArguments(arguments.length, 1, prefix);
name = webidl.converters.USVString(name, prefix, "Argument 1");
const list = this[_list];
let i = 0;
while (i < list.length) {
if (list[i][0] === name) {
ArrayPrototypeSplice(list, i, 1);
} else {
i++;
if (value === undefined) {
while (i < list.length) {
if (list[i][0] === name) {
ArrayPrototypeSplice(list, i, 1);
} else {
i++;
}
}
} else {
value = webidl.converters.USVString(value, prefix, "Argument 2");
while (i < list.length) {
if (list[i][0] === name && list[i][1] === value) {
ArrayPrototypeSplice(list, i, 1);
} else {
i++;
}
}
}
this.#updateUrlSearch();
@ -228,13 +240,21 @@ class URLSearchParams {
/**
* @param {string} name
* @param {string} [value]
* @return {boolean}
*/
has(name) {
has(name, value = undefined) {
webidl.assertBranded(this, URLSearchParamsPrototype);
const prefix = "Failed to execute 'has' on 'URLSearchParams'";
webidl.requiredArguments(arguments.length, 1, prefix);
name = webidl.converters.USVString(name, prefix, "Argument 1");
if (value !== undefined) {
value = webidl.converters.USVString(value, prefix, "Argument 2");
return ArrayPrototypeSome(
this[_list],
(entry) => entry[0] === name && entry[1] === value,
);
}
return ArrayPrototypeSome(this[_list], (entry) => entry[0] === name);
}

14
tools/wpt/expectation.json
View file

@ -3205,12 +3205,10 @@
"urlsearchparams-constructor.any.html": true,
"urlsearchparams-constructor.any.worker.html": true,
"urlsearchparams-delete.any.html": [
"Changing the query of a URL with an opaque path can impact the path",
"Two-argument delete()"
"Changing the query of a URL with an opaque path can impact the path"
],
"urlsearchparams-delete.any.worker.html": [
"Changing the query of a URL with an opaque path can impact the path",
"Two-argument delete()"
"Changing the query of a URL with an opaque path can impact the path"
],
"urlsearchparams-foreach.any.html": true,
"urlsearchparams-foreach.any.worker.html": true,
@ -3218,12 +3216,8 @@
"urlsearchparams-get.any.worker.html": true,
"urlsearchparams-getall.any.html": true,
"urlsearchparams-getall.any.worker.html": true,
"urlsearchparams-has.any.html": [
"Two-argument has()"
],
"urlsearchparams-has.any.worker.html": [
"Two-argument has()"
],
"urlsearchparams-has.any.html": true,
"urlsearchparams-has.any.worker.html": true,
"urlsearchparams-set.any.html": true,
"urlsearchparams-set.any.worker.html": true,
"urlsearchparams-size.any.html": true,