mirror of
https://github.com/denoland/deno.git
synced 2024-12-25 16:49:18 -05:00
wpt: unlock nightly with --no-ignore (#17998)
When I was testing the code in #17892 I had updated expectations and didn't catch this. This PR fixes the the expectation file format to not be checked when --no-ignore is passed during [nightly](https://github.com/denoland/deno/actions/runs/4319520368/jobs/7538796572#step:9:46) runs.
This commit is contained in:
parent
38555a6a0f
commit
1b42ab4605
2 changed files with 10 additions and 5 deletions
14
tools/wpt.ts
14
tools/wpt.ts
|
@ -249,8 +249,10 @@ async function generateWptReport(
|
|||
if (!case_.passed) {
|
||||
if (typeof test.expectation === "boolean") {
|
||||
expected = test.expectation ? "PASS" : "FAIL";
|
||||
} else {
|
||||
} else if (Array.isArray(test.expectation)) {
|
||||
expected = test.expectation.includes(case_.name) ? "FAIL" : "PASS";
|
||||
} else {
|
||||
expected = "PASS";
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -708,10 +710,12 @@ function discoverTestsToRun(
|
|||
}
|
||||
}
|
||||
|
||||
assert(
|
||||
Array.isArray(expectation) || typeof expectation == "boolean",
|
||||
"test entry must not have a folder expectation",
|
||||
);
|
||||
if (!noIgnore) {
|
||||
assert(
|
||||
Array.isArray(expectation) || typeof expectation == "boolean",
|
||||
"test entry must not have a folder expectation",
|
||||
);
|
||||
}
|
||||
|
||||
if (
|
||||
filter &&
|
||||
|
|
|
@ -98,6 +98,7 @@ export function getExpectFailForCase(
|
|||
expectation: boolean | string[],
|
||||
caseName: string,
|
||||
): boolean {
|
||||
if (noIgnore) return false;
|
||||
if (typeof expectation == "boolean") {
|
||||
return !expectation;
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue