foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-01-19 12:16:17 -05:00
Code Issues Packages 1 Wiki Activity

fix(ext/node): use primordials in ext/node/polyfills/_fs_common.ts (#27589)

Browse source 
Related to #24236
This commit is contained in:
Rajhans Jadhao 2025-01-10 18:21:50 +05:30 • committed by GitHub
parent 475793f94d
commit 1dd5bd667c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 13 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
ext/node/polyfills/_fs/_fs_common.ts
View file

@ -1,8 +1,12 @@
// Copyright 2018-2025 the Deno authors. MIT license.
// TODO(petamoriken): enable prefer-primordials for node polyfills
// deno-lint-ignore-file prefer-primordials
import { primordials } from "ext:core/mod.js";
const {
StringPrototypeToLowerCase,
ArrayPrototypeIncludes,
ReflectApply,
Error,
} = primordials;
import {
O_APPEND,
O_CREAT,
@ -85,8 +89,10 @@ export function getEncoding(
export function checkEncoding(encoding: Encodings | null): Encodings | null {
if (!encoding) return null;
encoding = encoding.toLowerCase() as Encodings;
if (["utf8", "hex", "base64", "ascii"].includes(encoding)) return encoding;
encoding = StringPrototypeToLowerCase(encoding) as Encodings;
if (ArrayPrototypeIncludes(["utf8", "hex", "base64", "ascii"], encoding)) {
return encoding;
}
if (encoding === "utf-8") {
return "utf8";
@ -99,7 +105,7 @@ export function checkEncoding(encoding: Encodings | null): Encodings | null {
const notImplementedEncodings = ["utf16le", "latin1", "ucs2"];
if (notImplementedEncodings.includes(encoding as string)) {
if (ArrayPrototypeIncludes(notImplementedEncodings, encoding as string)) {
notImplemented(`"${encoding}" encoding`);
}
@ -241,5 +247,5 @@ export function makeCallback(
) {
validateFunction(cb, "cb");
return (...args: unknown[]) => Reflect.apply(cb!, this, args);
return (...args: unknown[]) => ReflectApply(cb!, this, args);
}