foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-01 16:51:13 -05:00
Code Issues Packages 1 Wiki Activity

Remove from test_cc SnapshotterInitializesCorrectly (#1361)

Browse source 
Unfortunately V8 has a debug-only assert that checks
that a SnapshotCreator actually created a snapshot:
7d8c9aa769/v8/src/api.cc (L571)

This was not being triggered in Linux & Mac debug builds
because we were using the prebuilt release V8 build.
It was being triggered in Windows debug build because there is
a prebuilt v8_debug.lib. However the Windows error went unnoticed
because we only run release builds in CI.
This commit is contained in:
Ryan Dahl 2018-12-17 20:05:18 -05:00 committed by GitHub
parent 04076465cf
commit 1e54f1d473
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
libdeno/deno.h
View file

@ -36,6 +36,9 @@ typedef struct {
deno_recv_cb recv_cb; // Maps to libdeno.send() calls. deno_recv_cb recv_cb; // Maps to libdeno.send() calls.
} deno_config; } deno_config;
// Create a new deno isolate.
// Warning: If config.will_snapshot is set, deno_get_snapshot() must be called
// or an error will result.
Deno* deno_new(deno_config config); Deno* deno_new(deno_config config);
// Generate a snapshot. The resulting buf can be used with deno_new. // Generate a snapshot. The resulting buf can be used with deno_new.

5
libdeno/libdeno_test.cc
View file

@ -14,11 +14,6 @@ TEST(LibDenoTest, InitializesCorrectlyWithoutSnapshot) {
deno_delete(d); deno_delete(d);
} }
TEST(LibDenoTest, SnapshotterInitializesCorrectly) {
Deno* d = deno_new(deno_config{1, empty, empty, nullptr});
deno_delete(d);
}
TEST(LibDenoTest, Snapshotter) { TEST(LibDenoTest, Snapshotter) {
Deno* d1 = deno_new(deno_config{1, empty, empty, nullptr}); Deno* d1 = deno_new(deno_config{1, empty, empty, nullptr});
EXPECT_TRUE(deno_execute(d1, nullptr, "a.js", "a = 1 + 2")); EXPECT_TRUE(deno_execute(d1, nullptr, "a.js", "a = 1 + 2"));