mirror of
https://github.com/denoland/deno.git
synced 2024-11-28 16:20:57 -05:00
Remove from test_cc SnapshotterInitializesCorrectly (#1361)
Unfortunately V8 has a debug-only assert that checks
that a SnapshotCreator actually created a snapshot:
7d8c9aa769/v8/src/api.cc (L571)
This was not being triggered in Linux & Mac debug builds
because we were using the prebuilt release V8 build.
It was being triggered in Windows debug build because there is
a prebuilt v8_debug.lib. However the Windows error went unnoticed
because we only run release builds in CI.
This commit is contained in:
parent
04076465cf
commit
1e54f1d473
2 changed files with 3 additions and 5 deletions
|
@ -36,6 +36,9 @@ typedef struct {
|
|||
deno_recv_cb recv_cb; // Maps to libdeno.send() calls.
|
||||
} deno_config;
|
||||
|
||||
// Create a new deno isolate.
|
||||
// Warning: If config.will_snapshot is set, deno_get_snapshot() must be called
|
||||
// or an error will result.
|
||||
Deno* deno_new(deno_config config);
|
||||
|
||||
// Generate a snapshot. The resulting buf can be used with deno_new.
|
||||
|
|
|
@ -14,11 +14,6 @@ TEST(LibDenoTest, InitializesCorrectlyWithoutSnapshot) {
|
|||
deno_delete(d);
|
||||
}
|
||||
|
||||
TEST(LibDenoTest, SnapshotterInitializesCorrectly) {
|
||||
Deno* d = deno_new(deno_config{1, empty, empty, nullptr});
|
||||
deno_delete(d);
|
||||
}
|
||||
|
||||
TEST(LibDenoTest, Snapshotter) {
|
||||
Deno* d1 = deno_new(deno_config{1, empty, empty, nullptr});
|
||||
EXPECT_TRUE(deno_execute(d1, nullptr, "a.js", "a = 1 + 2"));
|
||||
|
|
Loading…
Reference in a new issue