refactor: add no-return-await lint rule (#4384)

.eslintrc.json

@@ -21,7 +21,8 @@
       { "argsIgnorePattern": "^_", "varsIgnorePattern": "^_" }
     ],
     "@typescript-eslint/ban-ts-ignore": ["off"],
-    "@typescript-eslint/no-empty-function": ["off"]
+    "@typescript-eslint/no-empty-function": ["off"],
+    "no-return-await": "error"
   },
   "overrides": [
     {

cli/js/ops/fetch.ts

@@ -24,5 +24,5 @@ export async function fetch(
     zeroCopy = new Uint8Array(body.buffer, body.byteOffset, body.byteLength);
   }
 
-  return await sendAsync("op_fetch", args, zeroCopy);
+  return sendAsync("op_fetch", args, zeroCopy);
 }

cli/js/ops/fs/make_temp.ts

@@ -14,7 +14,7 @@ export function makeTempDirSync(options: MakeTempOptions = {}): string {
 export async function makeTempDir(
   options: MakeTempOptions = {}
 ): Promise<string> {
-  return await sendAsync("op_make_temp_dir", options);
+  return sendAsync("op_make_temp_dir", options);
 }
 
 export function makeTempFileSync(options: MakeTempOptions = {}): string {
@@ -24,5 +24,5 @@ export function makeTempFileSync(options: MakeTempOptions = {}): string {
 export async function makeTempFile(
   options: MakeTempOptions = {}
 ): Promise<string> {
-  return await sendAsync("op_make_temp_file", options);
+  return sendAsync("op_make_temp_file", options);
 }

cli/js/ops/fs/open.ts

@@ -25,7 +25,7 @@ export async function open(
   mode: OpenMode | undefined,
   options: OpenOptions | undefined
 ): Promise<number> {
-  return await sendAsync("op_open", {
+  return sendAsync("op_open", {
     path,
     options,
     mode

cli/js/ops/fs/read_link.ts

@@ -6,5 +6,5 @@ export function readlinkSync(path: string): string {
 }
 
 export async function readlink(path: string): Promise<string> {
-  return await sendAsync("op_read_link", { path });
+  return sendAsync("op_read_link", { path });
 }

cli/js/ops/fs/realpath.ts

@@ -6,5 +6,5 @@ export function realpathSync(path: string): string {
 }
 
 export async function realpath(path: string): Promise<string> {
-  return await sendAsync("op_realpath", { path });
+  return sendAsync("op_realpath", { path });
 }

cli/js/ops/fs/seek.ts

@@ -15,5 +15,5 @@ export async function seek(
   offset: number,
   whence: SeekMode
 ): Promise<number> {
-  return await sendAsync("op_seek", { rid, offset, whence });
+  return sendAsync("op_seek", { rid, offset, whence });
 }

cli/js/ops/fs_events.ts

@@ -16,7 +16,7 @@ class FsEvents implements AsyncIterableIterator<FsEvent> {
   }
 
   async next(): Promise<IteratorResult<FsEvent>> {
-    return await sendAsync("op_fs_events_poll", {
+    return sendAsync("op_fs_events_poll", {
       rid: this.rid
     });
   }

cli/js/ops/net.ts

@@ -32,7 +32,7 @@ interface AcceptResponse {
 }
 
 export async function accept(rid: number): Promise<AcceptResponse> {
-  return await sendAsync("op_accept", { rid });
+  return sendAsync("op_accept", { rid });
 }
 
 export interface ListenRequest {
@@ -75,7 +75,7 @@ export interface ConnectRequest {
 }
 
 export async function connect(args: ConnectRequest): Promise<ConnectResponse> {
-  return await sendAsync("op_connect", args);
+  return sendAsync("op_connect", args);
 }
 
 interface ReceiveResponse {
@@ -91,7 +91,7 @@ export async function receive(
   rid: number,
   zeroCopy: Uint8Array
 ): Promise<ReceiveResponse> {
-  return await sendAsync("op_receive", { rid }, zeroCopy);
+  return sendAsync("op_receive", { rid }, zeroCopy);
 }
 
 export interface SendRequest {

cli/js/ops/process.ts

@@ -13,7 +13,7 @@ interface RunStatusResponse {
 }
 
 export async function runStatus(rid: number): Promise<RunStatusResponse> {
-  return await sendAsync("op_run_status", { rid });
+  return sendAsync("op_run_status", { rid });
 }
 
 interface RunRequest {

cli/js/ops/signal.ts

@@ -6,7 +6,7 @@ export function bindSignal(signo: number): { rid: number } {
 }
 
 export async function pollSignal(rid: number): Promise<{ done: boolean }> {
-  return await sendAsync("op_signal_poll", { rid });
+  return sendAsync("op_signal_poll", { rid });
 }
 
 export function unbindSignal(rid: number): void {

cli/js/ops/tls.ts

@@ -26,7 +26,7 @@ interface ConnectTLSResponse {
 export async function connectTLS(
   args: ConnectTLSRequest
 ): Promise<ConnectTLSResponse> {
-  return await sendAsync("op_connect_tls", args);
+  return sendAsync("op_connect_tls", args);
 }
 
 interface AcceptTLSResponse {
@@ -44,7 +44,7 @@ interface AcceptTLSResponse {
 }
 
 export async function acceptTLS(rid: number): Promise<AcceptTLSResponse> {
-  return await sendAsync("op_accept_tls", { rid });
+  return sendAsync("op_accept_tls", { rid });
 }
 
 export interface ListenTLSRequest {

cli/js/ops/worker_host.ts

@@ -25,5 +25,5 @@ export function hostPostMessage(id: number, data: Uint8Array): void {
 }
 
 export async function hostGetMessage(id: number): Promise<any> {
-  return await sendAsync("op_host_get_message", { id });
+  return sendAsync("op_host_get_message", { id });
 }

cli/js/process.ts

@@ -56,7 +56,7 @@ export class Process {
   }
 
   async status(): Promise<ProcessStatus> {
-    return await runStatus(this.rid);
+    return runStatus(this.rid);
   }
 
   async output(): Promise<Uint8Array> {

cli/js/tests/unit_test_runner.ts

@@ -312,14 +312,14 @@ async function main(): Promise<void> {
 
   // Master mode
   if (args.master) {
-    return await masterRunnerMain(args.verbose, filter);
+    return masterRunnerMain(args.verbose, filter);
   }
 
   // Worker mode
   if (args.worker) {
     assertOrHelp(typeof args.addr === "string");
     assertOrHelp(typeof args.perms === "string");
-    return await workerRunnerMain(args.addr, args.perms, filter);
+    return workerRunnerMain(args.addr, args.perms, filter);
   }
 
   // Running tests matching current process permissions

cli/js/web/fetch.ts

@@ -453,7 +453,7 @@ async function sendFetchReq(
     headers: headerArray
   };
 
-  return await opFetch(args, body);
+  return opFetch(args, body);
 }
 
 export async function fetch(

core/examples/http_bench.js

@@ -85,7 +85,7 @@ function listen() {
 
 /** Accepts a connection, returns rid. */
 async function accept(rid) {
-  return await sendAsync(ops["accept"], rid);
+  return sendAsync(ops["accept"], rid);
 }
 
 /**
@@ -93,12 +93,12 @@ async function accept(rid) {
  * Returns bytes read.
  */
 async function read(rid, data) {
-  return await sendAsync(ops["read"], rid, data);
+  return sendAsync(ops["read"], rid, data);
 }
 
 /** Writes a fixed HTTP response to the socket rid. Returns bytes written. */
 async function write(rid, data) {
-  return await sendAsync(ops["write"], rid, data);
+  return sendAsync(ops["write"], rid, data);
 }
 
 function close(rid) {

std/http/file_server.ts

@@ -126,7 +126,7 @@ async function serveDir(
     const fileUrl = posix.join(dirUrl, fileInfo.name ?? "");
     if (fileInfo.name === "index.html" && fileInfo.isFile()) {
       // in case index.html as dir...
-      return await serveFile(req, filePath);
+      return serveFile(req, filePath);
     }
     // Yuck!
     let mode = null;