foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-26 00:59:24 -05:00
Code Issues Packages 1 Wiki Activity

feat(web): Implement DOMException's stack property. (#12294)

Browse source 
As per WebIDL (https://heycam.github.io/webidl/#es-DOMException-specialness),
if `Error` objects have a `stack` property, so should `DOMException`
instances.
This commit is contained in:
Andreu Botella 2021-10-03 17:21:49 +02:00 committed by GitHub
parent 8884141c3f
commit 2170a41d97
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
ext/web/01_dom_exception.js
View file

@ -96,11 +96,16 @@
});
this.#code = nameToCodeMapping[this.#name] ?? 0;
// `DOMException` does not have `.stack`, so `Error.prepareStackTrace()`
// is not called on it, meaning our structured stack trace hack doesn't
// apply. This patches it in.
const error = new Error();
error.stack;
const error = new Error(`DOMException: ${this.#message}`);
ObjectDefineProperty(this, "stack", {
value: error.stack,
writable: true,
configurable: true,
});
// `DOMException` isn't a native error, so `Error.prepareStackTrace()` is
// not called when accessing `.stack`, meaning our structured stack trace
// hack doesn't apply. This patches it in.
ObjectDefineProperty(this, "__callSiteEvals", {
value: ArrayPrototypeSlice(error.__callSiteEvals, 1),
configurable: true,

6
tools/wpt/expectation.json
View file

@ -13603,9 +13603,7 @@
"DOMException-constants.any.html": true,
"DOMException-constructor-and-prototype.any.html": true,
"DOMException-constructor-behavior.any.html": true,
"DOMException-custom-bindings.any.html": [
"If the implementation has a stack property on normal errors, it also does on DOMExceptions"
]
"DOMException-custom-bindings.any.html": true
},
"class-string-interface.any.html": true,
"class-string-iterator-prototype-object.any.html": true,
@ -15339,4 +15337,4 @@
"Pattern: [] Inputs: []"
]
}
}
}