foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-24 15:19:26 -05:00
Code Issues Packages 1 Wiki Activity

fix(tls): print a warning if a system certificate can't be loaded (#25023)

Browse source 
This commit changes how system certificates are loaded on startup.

Instead of hard erroring if a certificate can't be decoded, we are now
printing a warning and bumping a hex representation of the certificate
and continue execution.

Ref https://github.com/denoland/deno/issues/24137
This commit is contained in:
Bartek Iwańczuk 2024-08-13 17:12:45 +01:00 committed by GitHub
parent 39a21fd78e
commit 25bb59d2ce
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 13 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
cli/args/mod.rs
View file

@ -640,8 +640,6 @@ pub enum RootCertStoreLoadError {
UnknownStore(String), UnknownStore(String),
#[error("Unable to add pem file to certificate store: {0}")] #[error("Unable to add pem file to certificate store: {0}")]
FailedAddPemFile(String), FailedAddPemFile(String),
#[error("Unable to add system certificate to certificate store: {0}")]
FailedAddSystemCert(String),
#[error("Failed opening CA file: {0}")] #[error("Failed opening CA file: {0}")]
CaFileOpenError(String), CaFileOpenError(String),
} }
@ -675,11 +673,19 @@ pub fn get_root_cert_store(
"system" => { "system" => {
let roots = load_native_certs().expect("could not load platform certs"); let roots = load_native_certs().expect("could not load platform certs");
for root in roots { for root in roots {
root_cert_store if let Err(err) = root_cert_store
.add(rustls::pki_types::CertificateDer::from(root.0)) .add(rustls::pki_types::CertificateDer::from(root.0.clone()))
.map_err(|e| { {
RootCertStoreLoadError::FailedAddSystemCert(e.to_string()) log::error!(
})?; "{}",
colors::yellow(&format!(
"Unable to add system certificate to certificate store: {:?}",
err
))
);
let hex_encoded_root = faster_hex::hex_string(&root.0);
log::error!("{}", colors::gray(&hex_encoded_root));
}
} }
} }
_ => { _ => {