foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-11 01:58:05 -05:00
Code Issues Packages 1 Wiki Activity

enable [node/http] client closing a streaming request doesn't terminate server

Browse source
This commit is contained in:
Yoshiya Hinosawa 2024-10-17 22:16:31 +09:00
parent 781eb00dfe
commit 2a290317d2
No known key found for this signature in database
GPG key ID: 9017DB4559488785
1 changed files with 69 additions and 75 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

144
tests/unit_node/http_test.ts
View file

@ -1377,91 +1377,85 @@ Deno.test("[node/http] client closing a streaming response doesn't terminate ser
clearInterval(interval!); clearInterval(interval!);
}); });
Deno.test( Deno.test("[node/http] client closing a streaming request doesn't terminate server", async () => {
"[node/http] client closing a streaming request doesn't terminate server", let interval: number;
{ let uploadedData = "";
ignore: true, let requestError: Error | null = null;
}, const server = http.createServer((req, res) => {
async () => { res.writeHead(200, { "Content-Type": "text/plain" });
let interval: number; interval = setInterval(() => {
let uploadedData = ""; res.write("Hello, world!\n");
let requestError: Error | null = null; }, 100);
const server = http.createServer((req, res) => { req.on("data", (chunk) => {
res.writeHead(200, { "Content-Type": "text/plain" }); uploadedData += chunk.toString();
interval = setInterval(() => {
res.write("Hello, world!\n");
}, 100);
req.on("data", (chunk) => {
uploadedData += chunk.toString();
});
req.on("end", () => {
clearInterval(interval);
});
req.on("error", (err) => {
requestError = err;
clearInterval(interval);
res.end();
});
}); });
req.on("end", () => {
clearInterval(interval);
});
req.on("error", (err) => {
requestError = err;
clearInterval(interval);
res.end();
});
});
const deferred1 = Promise.withResolvers<void>(); const deferred1 = Promise.withResolvers<void>();
server.listen(0, () => { server.listen(0, () => {
// deno-lint-ignore no-explicit-any // deno-lint-ignore no-explicit-any
const port = (server.address() as any).port; const port = (server.address() as any).port;
// Create a client connection to the server // Create a client connection to the server
const client = net.createConnection({ port }, () => { const client = net.createConnection({ port }, () => {
const headers = [ const headers = [
"POST /upload HTTP/1.1", "POST /upload HTTP/1.1",
"Host: localhost", "Host: localhost",
"Content-Type: text/plain", "Content-Type: text/plain",
"Transfer-Encoding: chunked", "Transfer-Encoding: chunked",
"", "",
"", "",
].join("\r\n"); ].join("\r\n");
client.write(headers); client.write(headers);
const chunk = "A".repeat(100); const chunk = "A".repeat(100);
let sentChunks = 0; let sentChunks = 0;
function writeChunk() { function writeChunk() {
const chunkHeader = `${chunk.length.toString(16)}\r\n`; const chunkHeader = `${chunk.length.toString(16)}\r\n`;
client.write(chunkHeader); client.write(chunkHeader);
client.write(chunk); client.write(chunk);
client.write("\r\n"); client.write("\r\n");
sentChunks++; sentChunks++;
if (sentChunks >= 3) { if (sentChunks >= 3) {
client.destroy(); client.destroy();
setTimeout(() => { setTimeout(() => {
deferred1.resolve(); deferred1.resolve();
}, 40); }, 40);
} else { } else {
setTimeout(writeChunk, 10); setTimeout(writeChunk, 10);
}
} }
writeChunk(); }
}); writeChunk();
}); });
});
await deferred1.promise; await deferred1.promise;
assert(requestError !== null, "Server should have received an error"); assert(requestError !== null, "Server should have received an error");
assert( assert(
(requestError! as Error)?.name === "Http", (requestError! as Error)?.name === "Http",
`Expected Http error, got ${(requestError! as Error)?.name}`, `Expected Http error, got ${(requestError! as Error)?.name}`,
); );
assert( assert(
(requestError! as Error)?.message.includes( (requestError! as Error)?.message.includes(
"error reading a body from connection", "error reading a body from connection",
), ),
); );
assertEquals(server.listening, true); assertEquals(server.listening, true);
server.close(); server.close();
assertEquals(server.listening, false); assertEquals(server.listening, false);
clearInterval(interval!); clearInterval(interval!);
}, });
);
Deno.test("[node/http] http.request() post streaming body works", async () => { Deno.test("[node/http] http.request() post streaming body works", async () => {
const server = http.createServer((req, res) => { const server = http.createServer((req, res) => {