foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-21 15:04:11 -05:00
Code Issues Packages 1 Wiki Activity

fix(node): Bump hardcoded version to latest (#20366)

Browse source 
When trying to run
```
deno run -A --unstable npm:astro dev
```
in my Astro project it fails with:
```
Node.js v18.12.1 is not supported by Astro!
Please upgrade Node.js to a supported version: ">=18.14.1"
```
My current version is:
```
~ ❯ node --version
v20.5.1
```

Bumping the version to the latest stable Release of node in
`ext/node/polyfills/_process/process.ts` fixes this.
I don't know if this causes any conflicts, so please feel free to
correct me here.
This commit is contained in:
Fabian 2023-09-04 12:33:15 +02:00 committed by GitHub
parent 1dc5d42114
commit 2cc7c8432f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ext/node/polyfills/_process/process.ts
View file

@ -102,7 +102,7 @@ export const env: InstanceType<ObjectConstructor> & Record<string, string> =
* it pointed to Deno version, but that led to incompability
* with some packages.
*/
export const version = "v18.12.1";
export const version = "v18.17.1";
/**
* https://nodejs.org/api/process.html#process_process_versions
@ -113,7 +113,7 @@ export const version = "v18.12.1";
* with some packages. Value of `v8` field is still taken from `Deno.version`.
*/
export const versions = {
node: "18.12.1",
node: "18.17.1",
uv: "1.43.0",
zlib: "1.2.11",
brotli: "1.0.9",