foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-22 07:14:47 -05:00
Code Issues Packages 1 Wiki Activity

fix(cli) Better error messages on corrupt databases that aren't automatically re-created (#18330)

Browse source
This commit is contained in:
Matt Mastracci 2023-03-21 11:19:10 -06:00 committed by GitHub
parent 08849a48ca
commit 2ef8269fdb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
cli/cache/node.rs vendored
View file

@ -106,11 +106,16 @@ impl NodeAnalysisCache {
) { ) {
Ok(cache) => Some(cache), Ok(cache) => Some(cache),
Err(err) => { Err(err) => {
let file = self
.db_file_path
.as_ref()
.map(|s| s.to_string_lossy().to_string())
.unwrap_or_default();
log::error!("Error creating node analysis cache, file '{file}' may be corrupt: {:#}", err);
// should never error here, but if it ever does don't fail // should never error here, but if it ever does don't fail
if cfg!(debug_assertions) { if cfg!(debug_assertions) {
panic!("Error creating node analysis cache: {err:#}"); panic!("Error creating node analysis cache, file '{file}' may be corrupt: {err:#}");
} else { } else {
log::debug!("Error creating node analysis cache: {:#}", err);
None None
} }
} }

7
cli/cache/parsed_source.rs vendored
View file

@ -121,7 +121,12 @@ impl ParsedSourceCache {
) { ) {
Ok(analyzer) => Box::new(analyzer), Ok(analyzer) => Box::new(analyzer),
Err(err) => { Err(err) => {
log::debug!("Could not create cached module analyzer. {:#}", err); let file = self
.db_cache_path
.as_ref()
.map(|s| s.to_string_lossy().to_string())
.unwrap_or_default();
log::error!("Could not create cached module analyzer, cache file '{file}' may be corrupt: {:#}", err);
// fallback to not caching if it can't be created // fallback to not caching if it can't be created
Box::new(deno_graph::CapturingModuleAnalyzer::new( Box::new(deno_graph::CapturingModuleAnalyzer::new(
None, None,