foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-25 15:29:32 -05:00
Code Issues Packages 1 Wiki Activity

chore(cli): Fix test that locks up on some M2 macs (#19989)

Browse source 
I'm not sure why, but sending SIGABRT to Deno on my machine as part of
this test causes it to lock up very badly, leaving it in an unkillable
`UE+` state.

This showed up after #19333, but was not caused by it.
This commit is contained in:
Matt Mastracci 2023-07-31 07:29:00 -06:00 committed by GitHub
parent 02865cb5a2
commit 2fd87471e8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
cli/tests/unit_node/child_process_test.ts
View file

@ -626,12 +626,12 @@ Deno.test({
name: "[node/child_process spawn] supports SIGIOT signal", name: "[node/child_process spawn] supports SIGIOT signal",
ignore: Deno.build.os === "windows", ignore: Deno.build.os === "windows",
async fn() { async fn() {
const script = path.join( // Note: attempting to kill Deno with SIGABRT causes the process to zombify on certain OSX builds
path.dirname(path.fromFileUrl(import.meta.url)), // eg: 22.5.0 Darwin Kernel Version 22.5.0: Mon Apr 24 20:53:19 PDT 2023; root:xnu-8796.121.2~5/RELEASE_ARM64_T6020 arm64
"testdata", // M2 Pro running Ventura 13.4
"child_process_stdin.js",
); // Spawn an infinite cat
const cp = spawn(Deno.execPath(), ["run", "-A", script]); const cp = spawn("cat", ["-"]);
const p = withTimeout(); const p = withTimeout();
cp.on("exit", () => p.resolve()); cp.on("exit", () => p.resolve());
cp.kill("SIGIOT"); cp.kill("SIGIOT");