move js unit tests to cli/tests (#5678)

cli/tests/integration_tests.rs

@@ -400,7 +400,7 @@ fn js_unit_tests() {
     .arg("--unstable")
     .arg("--reload")
     .arg("-A")
-    .arg("cli/js/tests/unit_test_runner.ts")
+    .arg("cli/tests/unit/unit_test_runner.ts")
     .arg("--master")
     .arg("--verbose")
     .env("NO_COLOR", "1")

cli/tests/unit/README.md

@@ -42,7 +42,7 @@ ways:
 `unit_test_runner.ts` is the main script used to run unit tests.
 
 Runner discovers required permissions combinations by loading
-`cli/js/tests/unit_tests.ts` and going through all registered instances of
+`cli/tests/unit/unit_tests.ts` and going through all registered instances of
 `unitTest`.
 
 There are three ways to run `unit_test_runner.ts`:
@@ -50,27 +50,27 @@ There are three ways to run `unit_test_runner.ts`:
 ```
 # Run all tests. Spawns worker processes for each discovered permission
 # combination:
-target/debug/deno run -A cli/js/tests/unit_test_runner.ts --master
+target/debug/deno run -A cli/tests/unit/unit_test_runner.ts --master
 
 # By default all output of worker processes is discarded; for debug purposes
 # the --verbose flag preserves output from the worker
-target/debug/deno run -A cli/js/tests/unit_test_runner.ts --master --verbose
+target/debug/deno run -A cli/tests/unit/unit_test_runner.ts --master --verbose
 
 # Run subset of tests that don't require any permissions
-target/debug/deno run --unstable cli/js/tests/unit_test_runner.ts
+target/debug/deno run --unstable cli/tests/unit/unit_test_runner.ts
 
 # Run subset tests that require "net" and "read" permissions
-target/debug/deno run --unstable --allow-net --allow-read cli/js/tests/unit_test_runner.ts
+target/debug/deno run --unstable --allow-net --allow-read cli/tests/unit/unit_test_runner.ts
 
 # "worker" mode communicates with parent using TCP socket on provided address;
 # after initial setup drops permissions to specified set. It shouldn't be used
 # directly, only be "master" process.
-target/debug/deno run -A cli/js/tests/unit_test_runner.ts --worker --addr=127.0.0.1:4500 --perms=net,write,run
+target/debug/deno run -A cli/tests/unit/unit_test_runner.ts --worker --addr=127.0.0.1:4500 --perms=net,write,run
 
 # Run specific tests
-target/debug/deno run --unstable --allow-net cli/js/tests/unit_test_runner.ts -- netTcpListenClose
+target/debug/deno run --unstable --allow-net cli/tests/unit/unit_test_runner.ts -- netTcpListenClose
 
-RUST_BACKTRACE=1 cargo run -- run --unstable --allow-read --allow-write cli/js/tests/unit_test_runner.ts -- netUnixDialListen
+RUST_BACKTRACE=1 cargo run -- run --unstable --allow-read --allow-write cli/tests/unit/unit_test_runner.ts -- netUnixDialListen
 ```
 
 ### Http server

cli/tests/unit/test_util.ts

@@ -327,12 +327,12 @@ unitTest(function permissionsMatches(): void {
 
 /*
  * Ensure all unit test files (e.g. xxx_test.ts) are present as imports in
- * cli/js/tests/unit_tests.ts as it is easy to miss this out
+ * cli/tests/unit/unit_tests.ts as it is easy to miss this out
  */
 unitTest(
   { perms: { read: true } },
   function assertAllUnitTestFilesImported(): void {
-    const directoryTestFiles = [...Deno.readDirSync("./cli/js/tests/")]
+    const directoryTestFiles = [...Deno.readDirSync("./cli/tests/unit/")]
       .map((k) => k.name)
       .filter(
         (file) =>
@@ -342,7 +342,7 @@ unitTest(
           !file!.endsWith("unit_test_runner.ts")
       );
     const unitTestsFile: Uint8Array = Deno.readFileSync(
-      "./cli/js/tests/unit_tests.ts"
+      "./cli/tests/unit/unit_tests.ts"
     );
     const importLines = new TextDecoder("utf-8")
       .decode(unitTestsFile)
@@ -355,7 +355,7 @@ unitTest(
     directoryTestFiles.forEach((dirFile) => {
       if (!importedTestFiles.includes(dirFile!)) {
         throw new Error(
-          "cil/js/tests/unit_tests.ts is missing import of test file: cli/js/" +
+          "cil/tests/unit/unit_tests.ts is missing import of test file: cli/js/" +
             dirFile
         );
       }

cli/tests/unit/unit_test_runner.ts

@@ -96,7 +96,7 @@ function spawnWorkerRunner(
     "run",
     "--unstable", // TODO(ry) be able to test stable vs unstable
     "-A",
-    "cli/js/tests/unit_test_runner.ts",
+    "cli/tests/unit/unit_test_runner.ts",
     "--worker",
     `--addr=${addr}`,
     `--perms=${permStr}`,