foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-22 07:14:47 -05:00
Code Issues Packages 1 Wiki Activity

Make shutdown unstable and async (#4940)

Browse source
This commit is contained in:
Luca Casonato 2020-04-28 07:36:47 +02:00 committed by GitHub
parent de751e5221
commit 30dc9bb748
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cli/js/lib.deno.ns.d.ts vendored
View file

@ -1872,7 +1872,7 @@ declare namespace Deno {
* const conn = await listener.accept(); * const conn = await listener.accept();
* Deno.shutdown(conn.rid, Deno.ShutdownMode.Write); * Deno.shutdown(conn.rid, Deno.ShutdownMode.Write);
*/ */
export function shutdown(rid: number, how: ShutdownMode): void; export function shutdown(rid: number, how: ShutdownMode): Promise<void>;
/** **UNSTABLE**: new API, yet to be vetted. /** **UNSTABLE**: new API, yet to be vetted.
* *

3
cli/js/ops/net.ts
View file

@ -22,8 +22,9 @@ export enum ShutdownMode {
ReadWrite, // unused ReadWrite, // unused
} }
export function shutdown(rid: number, how: ShutdownMode): void { export function shutdown(rid: number, how: ShutdownMode): Promise<void> {
sendSync("op_shutdown", { rid, how }); sendSync("op_shutdown", { rid, how });
return Promise.resolve();
} }
interface AcceptResponse { interface AcceptResponse {

4
cli/ops/net.rs
View file

@ -342,10 +342,12 @@ struct ShutdownArgs {
fn op_shutdown( fn op_shutdown(
isolate: &mut CoreIsolate, isolate: &mut CoreIsolate,
_state: &State, state: &State,
args: Value, args: Value,
_zero_copy: Option<ZeroCopyBuf>, _zero_copy: Option<ZeroCopyBuf>,
) -> Result<JsonOp, OpError> { ) -> Result<JsonOp, OpError> {
state.check_unstable("Deno.shutdown");
let args: ShutdownArgs = serde_json::from_value(args)?; let args: ShutdownArgs = serde_json::from_value(args)?;
let rid = args.rid as u32; let rid = args.rid as u32;