foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-28 16:20:57 -05:00
Code Issues Packages 1 Wiki Activity

Revert "feat(cli): enable useUnknownInCatchVariables by default" (#12643)

Browse source 
This partially reverts commit a065604155.

Co-authored-by: Kitson Kelly <me@kitsonkelly.com>
This commit is contained in:
Luca Casonato 2021-11-04 11:30:37 +01:00 committed by GitHub
parent 7c2abb9d57
commit 318dcc33af
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 6 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
cli/emit.rs
View file

@ -160,6 +160,8 @@ pub(crate) fn get_ts_config(
"target": "esnext", "target": "esnext",
"tsBuildInfoFile": "deno:///.tsbuildinfo", "tsBuildInfoFile": "deno:///.tsbuildinfo",
"useDefineForClassFields": true, "useDefineForClassFields": true,
// TODO(@kitsonk) remove for Deno 2.0
"useUnknownInCatchVariables": false,
})); }));
if tsc_emit { if tsc_emit {
ts_config.merge(&json!({ ts_config.merge(&json!({
@ -211,6 +213,8 @@ pub(crate) fn get_ts_config(
"target": "esnext", "target": "esnext",
"tsBuildInfoFile": "deno:///.tsbuildinfo", "tsBuildInfoFile": "deno:///.tsbuildinfo",
"useDefineForClassFields": true, "useDefineForClassFields": true,
// TODO(@kitsonk) remove for Deno 2.0
"useUnknownInCatchVariables": false,
})); }));
if tsc_emit { if tsc_emit {
ts_config.merge(&json!({ ts_config.merge(&json!({

2
cli/lsp/language_server.rs
View file

@ -572,6 +572,8 @@ impl Inner {
"strict": true, "strict": true,
"target": "esnext", "target": "esnext",
"useDefineForClassFields": true, "useDefineForClassFields": true,
// TODO(@kitsonk) remove for Deno 1.15
"useUnknownInCatchVariables": false,
})); }));
let config = &self.config; let config = &self.config;
let workspace_settings = config.get_workspace_settings(); let workspace_settings = config.get_workspace_settings();

7
cli/tests/integration/run_tests.rs
View file

@ -1367,13 +1367,6 @@ itest!(error_import_map_unable_to_load {
exit_code: 1, exit_code: 1,
}); });
// This test ensure that useUnknownInCatchVariables is enabled by default.
itest!(use_unknown_in_catch_variables {
args: "run useUnknownInCatchVariables.ts",
output: "useUnknownInCatchVariables.ts.out",
exit_code: 1,
});
// Test that setting `self` in the main thread to some other value doesn't break // Test that setting `self` in the main thread to some other value doesn't break
// the world. // the world.
itest!(replace_self { itest!(replace_self {

5
cli/tests/testdata/useUnknownInCatchVariables.ts vendored
View file

@ -1,5 +0,0 @@
try {
throw new Error();
} catch (e) {
console.log(e.message);
}

5
cli/tests/testdata/useUnknownInCatchVariables.ts.out vendored
View file

@ -1,5 +0,0 @@
[WILDCARD]
error: TS2571 [ERROR]: Object is of type 'unknown'.
console.log(e.message);
^
at file://[WILDCARD]/useUnknownInCatchVariables.ts:4:15