foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-01-19 04:16:00 -05:00
Code Issues Packages 1 Wiki Activity

fix(ext/node): propagate socket error to client request object (#27678)

Browse source 
Co-authored-by: Satya Rohith <me@satyarohith.com>
This commit is contained in:
Yoshiya Hinosawa 2025-01-17 12:30:00 +09:00 • committed by GitHub
parent 94dc5b16f5
commit 339bc44c58
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 24 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
ext/node/polyfills/http.ts
View file

@ -455,8 +455,13 @@ class ClientRequest extends OutgoingMessage {
(async () => {
try {
const parsedUrl = new URL(url);
let baseConnRid =
this.socket._handle[kStreamBaseField][internalRidSymbol];
const handle = this.socket._handle;
if (!handle) {
// Using non-standard socket. There's no way to handle this type of socket.
// This should be only happening in artificial test cases
return;
}
let baseConnRid = handle[kStreamBaseField][internalRidSymbol];
if (this._encrypted) {
[baseConnRid] = op_tls_start({
rid: baseConnRid,
@ -637,6 +642,12 @@ class ClientRequest extends OutgoingMessage {
};
this.socket = socket;
this.emit("socket", socket);
socket.once("error", (err) => {
// This callback loosely follow `socketErrorListener` in Node.js
// https://github.com/nodejs/node/blob/f16cd10946ca9ad272f42b94f00cf960571c9181/lib/_http_client.js#L509
emitErrorEvent(this, err);
socket.destroy(err);
});
if (socket.readyState === "opening") {
socket.on("connect", onConnect);
} else {

11
tests/unit_node/http_test.ts
View file

@ -1881,3 +1881,14 @@ Deno.test("[node/http] decompress brotli response", {
"localhost:3000",
], ["user-agent", "Deno/2.1.1"]]);
});
Deno.test("[node/http] an error with DNS propagates to request object", async () => {
const { resolve, promise } = Promise.withResolvers<void>();
const req = http.request("http://invalid-hostname.test", () => {});
req.on("error", (err) => {
assertEquals(err.name, "Error");
assertEquals(err.message, "getaddrinfo ENOTFOUND invalid-hostname.test");
resolve();
});
await promise;
});