foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-21 15:04:11 -05:00
Code Issues Packages 1 Wiki Activity

fix(ext/node): allow null value for req.setHeader (#21391)

Browse source 
Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
This commit is contained in:
Yoshiya Hinosawa 2023-12-08 17:43:19 +09:00 committed by GitHub
parent 2b3daa690d
commit 3a74fa60ca
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
cli/tests/unit_node/http_test.ts
View file

@ -835,3 +835,22 @@ Deno.test("[node/https] node:https exports globalAgent", async () => {
"node:https must export 'globalAgent' on module default export",
);
});
Deno.test("[node/http] node:http request.setHeader(header, null) doesn't throw", () => {
{
const req = http.request("http://localhost:4545/");
req.on("error", () => {});
// @ts-expect-error - null is not a valid header value
req.setHeader("foo", null);
req.end();
req.destroy();
}
{
const req = https.request("https://localhost:4545/");
req.on("error", () => {});
// @ts-expect-error - null is not a valid header value
req.setHeader("foo", null);
req.end();
req.destroy();
}
});

2
ext/node/polyfills/_http_outgoing.ts
View file

@ -249,7 +249,7 @@ export class OutgoingMessage extends Stream {
}
name = name.toString();
headers[name.toLowerCase()] = [name, value.toString()];
headers[name.toLowerCase()] = [name, String(value)];
return this;
}