foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-25 00:29:09 -05:00
Code Issues Packages 1 Wiki Activity

perf(lsp): don't pass remote modules as tsc roots (#23259)

Browse source
This commit is contained in:
Nayeem Rahman 2024-04-08 19:45:20 +01:00 committed by GitHub
parent 9752a153ea
commit 3c346c8ea6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
cli/lsp/documents.rs
View file

@ -1146,6 +1146,13 @@ impl Documents {
} }
} }
pub fn is_open(&self, specifier: &ModuleSpecifier) -> bool {
let Some(specifier) = self.resolve_specifier(specifier) else {
return false;
};
self.open_docs.contains_key(&specifier)
}
/// Return a collection of documents that are contained in the document store /// Return a collection of documents that are contained in the document store
/// based on the provided filter. /// based on the provided filter.
pub fn documents(&self, filter: DocumentsFilter) -> Vec<Arc<Document>> { pub fn documents(&self, filter: DocumentsFilter) -> Vec<Arc<Document>> {

4
cli/lsp/tsc.rs
View file

@ -4064,7 +4064,9 @@ fn op_script_names(state: &mut OpState) -> Vec<String> {
if seen.insert(specifier.as_str()) { if seen.insert(specifier.as_str()) {
if let Some(specifier) = documents.resolve_specifier(specifier) { if let Some(specifier) = documents.resolve_specifier(specifier) {
// only include dependencies we know to exist otherwise typescript will error // only include dependencies we know to exist otherwise typescript will error
if documents.exists(&specifier) { if documents.exists(&specifier)
&& (specifier.scheme() == "file" || documents.is_open(&specifier))
{
result.push(specifier.to_string()); result.push(specifier.to_string());
} }
} }

2
cli/tsc/99_main_compiler.js
View file

@ -550,7 +550,7 @@ delete Object.prototype.__proto__;
ts.toPath( ts.toPath(
fileName, fileName,
this.getCurrentDirectory(), this.getCurrentDirectory(),
this.getCanonicalFileName(fileName), this.getCanonicalFileName.bind(this),
); );
}, },
// @ts-ignore Undocumented method. // @ts-ignore Undocumented method.