foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-21 15:04:11 -05:00
Code Issues Packages 1 Wiki Activity

fix: replace npm install hint with deno install hint (#25244)

Browse source 
Needed for https://github.com/denoland/deno/pull/25213.

With Deno 2, we should suggest using `deno install` instead of `npm
install`.
This commit is contained in:
Bartek Iwańczuk 2024-08-28 03:31:41 +01:00 committed by GitHub
parent 1a6fd38f2f
commit 3dba98532a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 4 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
cli/npm/byonm.rs
View file

@ -307,14 +307,9 @@ impl CliNpmResolver for ByonmCliNpmResolver {
concat!( concat!(
"Could not find \"{}\" in a node_modules folder. ", "Could not find \"{}\" in a node_modules folder. ",
"Deno expects the node_modules/ directory to be up to date. ", "Deno expects the node_modules/ directory to be up to date. ",
"Did you forget to run `{}`?" "Did you forget to run `deno install`?"
), ),
alias, alias,
if *crate::args::DENO_FUTURE {
"deno install"
} else {
"npm install"
}
); );
} }

2
cli/resolver.rs
View file

@ -146,7 +146,7 @@ impl CliNodeResolver {
concat!( concat!(
"Could not resolve \"{}\", but found it in a package.json. ", "Could not resolve \"{}\", but found it in a package.json. ",
"Deno expects the node_modules/ directory to be up to date. ", "Deno expects the node_modules/ directory to be up to date. ",
"Did you forget to run `npm install`?" "Did you forget to run `deno install`?"
), ),
specifier specifier
)); ));

2
tests/integration/npm_tests.rs
View file

@ -2404,7 +2404,7 @@ fn byonm_package_specifier_not_installed_and_invalid_subpath() {
// no npm install has been run, so this should give an informative error // no npm install has been run, so this should give an informative error
let output = test_context.new_command().args("run main.ts").run(); let output = test_context.new_command().args("run main.ts").run();
output.assert_matches_text( output.assert_matches_text(
r#"error: Could not resolve "chalk", but found it in a package.json. Deno expects the node_modules/ directory to be up to date. Did you forget to run `npm install`? r#"error: Could not resolve "chalk", but found it in a package.json. Deno expects the node_modules/ directory to be up to date. Did you forget to run `deno install`?
at file:///[WILDCARD]/main.ts:1:19 at file:///[WILDCARD]/main.ts:1:19
"#, "#,
); );

2
tests/specs/npm/byonm/not_installed.out
View file

@ -1,2 +1,2 @@
error: Could not find "chalk" in a node_modules folder. Deno expects the node_modules/ directory to be up to date. Did you forget to run `npm install`? error: Could not find "chalk" in a node_modules folder. Deno expects the node_modules/ directory to be up to date. Did you forget to run `deno install`?
at file:///[WILDCARD]/not_installed.ts:1:19 at file:///[WILDCARD]/not_installed.ts:1:19