mirror of
https://github.com/denoland/deno.git
synced 2025-01-09 15:48:16 -05:00
feat(std/http): Add Cookie value validation (#8471)
This commit is contained in:
parent
5560a6d589
commit
447f3fe410
2 changed files with 66 additions and 0 deletions
|
@ -40,6 +40,7 @@ function toString(cookie: Cookie): string {
|
||||||
}
|
}
|
||||||
const out: string[] = [];
|
const out: string[] = [];
|
||||||
validateCookieName(cookie.name);
|
validateCookieName(cookie.name);
|
||||||
|
validateCookieValue(cookie.name, cookie.value);
|
||||||
out.push(`${cookie.name}=${cookie.value}`);
|
out.push(`${cookie.name}=${cookie.value}`);
|
||||||
|
|
||||||
// Fallback for invalid Set-Cookie
|
// Fallback for invalid Set-Cookie
|
||||||
|
@ -114,6 +115,33 @@ function validatePath(path: string | null): void {
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
*Validate Cookie Value.
|
||||||
|
* @see https://tools.ietf.org/html/rfc6265#section-4.1
|
||||||
|
* @param value Cookie value.
|
||||||
|
*/
|
||||||
|
function validateCookieValue(name: string, value: string | null): void {
|
||||||
|
if (value == null || name == null) return;
|
||||||
|
for (let i = 0; i < value.length; i++) {
|
||||||
|
const c = value.charAt(i);
|
||||||
|
if (
|
||||||
|
c < String.fromCharCode(0x21) || c == String.fromCharCode(0x22) ||
|
||||||
|
c == String.fromCharCode(0x2c) || c == String.fromCharCode(0x3b) ||
|
||||||
|
c == String.fromCharCode(0x5c) || c == String.fromCharCode(0x7f)
|
||||||
|
) {
|
||||||
|
throw new Error(
|
||||||
|
"RFC2616 cookie '" + name + "' cannot have '" + c + "' as value",
|
||||||
|
);
|
||||||
|
}
|
||||||
|
if (c > String.fromCharCode(0x80)) {
|
||||||
|
throw new Error(
|
||||||
|
"RFC2616 cookie '" + name + "' can only have US-ASCII chars as value" +
|
||||||
|
c.charCodeAt(0).toString(16),
|
||||||
|
);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Parse the cookies of the Server Request
|
* Parse the cookies of the Server Request
|
||||||
* @param req An object which has a `headers` property
|
* @param req An object which has a `headers` property
|
||||||
|
|
|
@ -65,6 +65,44 @@ Deno.test({
|
||||||
},
|
},
|
||||||
});
|
});
|
||||||
|
|
||||||
|
Deno.test({
|
||||||
|
name: "Cookie Value Validation",
|
||||||
|
fn(): void {
|
||||||
|
const res: Response = {};
|
||||||
|
const tokens = [
|
||||||
|
"1f\tWa",
|
||||||
|
"\t",
|
||||||
|
"1f Wa",
|
||||||
|
"1f;Wa",
|
||||||
|
'"1fWa',
|
||||||
|
"1f\\Wa",
|
||||||
|
'1f"Wa',
|
||||||
|
'"',
|
||||||
|
"1fWa\u0005",
|
||||||
|
"1f\u0091Wa",
|
||||||
|
];
|
||||||
|
res.headers = new Headers();
|
||||||
|
tokens.forEach((value) => {
|
||||||
|
assertThrows(
|
||||||
|
(): void => {
|
||||||
|
setCookie(
|
||||||
|
res,
|
||||||
|
{
|
||||||
|
name: "Space",
|
||||||
|
value,
|
||||||
|
httpOnly: true,
|
||||||
|
secure: true,
|
||||||
|
maxAge: 3,
|
||||||
|
},
|
||||||
|
);
|
||||||
|
},
|
||||||
|
Error,
|
||||||
|
"RFC2616 cookie 'Space'",
|
||||||
|
);
|
||||||
|
});
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
Deno.test({
|
Deno.test({
|
||||||
name: "Cookie Path Validation",
|
name: "Cookie Path Validation",
|
||||||
fn(): void {
|
fn(): void {
|
||||||
|
|
Loading…
Reference in a new issue