foster/denoland-deno
0
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-10-29 08:58:01 -04:00
Code Issues Wiki Activity

fix(lint): use recommended tags when no tags specified in config, but includes or excludes are (#12700)

Browse source
This commit is contained in:
David Sherret 2021-11-08 20:10:33 -05:00 committed by GitHub
parent 66974a8794
commit 45425c1146
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 34 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
cli/tools/lint.rs
View file

@ -530,7 +530,7 @@ pub(crate) fn get_configured_rules(
};
let configured_rules = rules::get_filtered_rules(
maybe_configured_tags,
maybe_configured_tags.or_else(|| Some(vec!["recommended".to_string()])),
maybe_configured_exclude,
maybe_configured_include,
);
@ -541,3 +541,36 @@ pub(crate) fn get_configured_rules(
Ok(configured_rules)
}
#[cfg(test)]
mod test {
use deno_lint::rules::get_recommended_rules;
use super::*;
use crate::config_file::LintRulesConfig;
#[test]
fn recommended_rules_when_no_tags_in_config() {
let lint_config = LintConfig {
rules: LintRulesConfig {
exclude: Some(vec!["no-debugger".to_string()]),
..Default::default()
},
..Default::default()
};
let rules =
get_configured_rules(Some(&lint_config), None, None, None).unwrap();
let mut rule_names = rules
.into_iter()
.map(|r| r.code().to_string())
.collect::<Vec<_>>();
rule_names.sort();
let mut recommended_rule_names = get_recommended_rules()
.into_iter()
.map(|r| r.code().to_string())
.filter(|n| n != "no-debugger")
.collect::<Vec<_>>();
recommended_rule_names.sort();
assert_eq!(rule_names, recommended_rule_names);
}
}