foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-31 11:34:15 -05:00
Code Issues Packages 1 Wiki Activity

feat(unstable): Await return from Jupyter.display (#20807)

Browse source 
Allows `Jupyter.display` to return a promise.

Example:

```javascript
class WikiPage {
    constructor(public name) {}
    async [Symbol.for("Jupyter.display")]() {
        let response = await fetch("https://en.wikipedia.org/wiki/" + this.name);
        return { "text/html": await response.text() }
    }
}

new WikiPage("Deno_(software)")
```
This commit is contained in:
Trevor Manz 2023-10-06 17:26:11 -04:00 committed by GitHub
parent ceecd8c495
commit 48bb3b2b0f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 40 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

37
cli/tests/testdata/jupyter/integration_test.ipynb vendored
View file

@ -827,6 +827,43 @@
"let sc = new SuperColor()\n",
"sc"
]
},
{
"cell_type": "code",
"execution_count": 27,
"id": "c1296291-a3e8-457b-8329-6cc58a1e528a",
"metadata": {},
"outputs": [
{
"data": {
"text/html": [
"<div style=\"width: 32px; height: 32px; background-color: #239814\" />"
]
},
"execution_count": 27,
"metadata": {},
"output_type": "execute_result"
}
],
"source": [
"class SuperColorAsync {\n",
" constructor() {\n",
" this.color = \"#239814\"\n",
" }\n",
" hex() {\n",
" return this.color\n",
" }\n",
" \n",
" async [Symbol.for(\"Jupyter.display\")]() {\n",
" return {\n",
" \"text/html\": `<div style=\"width: 32px; height: 32px; background-color: ${this.hex()}\" />`\n",
" }\n",
" }\n",
"}\n",
"\n",
"let sc = new SuperColorAsync()\n",
"sc"
]
}
],
"metadata": {

6
cli/tools/jupyter/server.rs
View file

@ -551,13 +551,13 @@ async fn get_jupyter_display(
.post_message_with_event_loop(
"Runtime.callFunctionOn",
Some(json!({
"functionDeclaration": r#"function (object) {
"functionDeclaration": r#"async function (object) {
if (typeof object[Symbol.for("Jupyter.display")] !== "function") {
return null;
}
try {
const representation = object[Symbol.for("Jupyter.display")]();
const representation = await object[Symbol.for("Jupyter.display")]();
return JSON.stringify(representation);
} catch {
return null;