foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-01-11 08:33:43 -05:00
Code Issues Packages 1 Wiki Activity

fix(ext/http): Include hostname in onListen argument (#19497)

Browse source 
Closes #19470.
This commit is contained in:
Jhan S. Álvarez 2023-06-14 07:58:41 -05:00 committed by GitHub
parent ec8e9d4f5b
commit 4b67ffe11b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
ext/http/00_serve.js
View file

@ -635,16 +635,17 @@ function serve(arg1, arg2) {
} }
const onListen = (scheme) => { const onListen = (scheme) => {
// If the hostname is "0.0.0.0", we display "localhost" in console
// because browsers in Windows don't resolve "0.0.0.0".
// See the discussion in https://github.com/denoland/deno_std/issues/1165
const hostname = listenOpts.hostname == "0.0.0.0"
? "localhost"
: listenOpts.hostname;
const port = listenOpts.port; const port = listenOpts.port;
if (options.onListen) { if (options.onListen) {
options.onListen({ port }); options.onListen({ hostname, port });
} else { } else {
// If the hostname is "0.0.0.0", we display "localhost" in console
// because browsers in Windows don't resolve "0.0.0.0".
// See the discussion in https://github.com/denoland/deno_std/issues/1165
const hostname = listenOpts.hostname == "0.0.0.0"
? "localhost"
: listenOpts.hostname;
console.log(`Listening on ${scheme}${hostname}:${port}/`); console.log(`Listening on ${scheme}${hostname}:${port}/`);
} }
}; };