From 4c2a00b034ef688d206d6b76e7648c2d8ca17258 Mon Sep 17 00:00:00 2001 From: Kenta Moriuchi Date: Sat, 6 Jan 2024 00:03:06 +0900 Subject: [PATCH] chore: update deno_lint for CI (#21802) --- ext/node/polyfills/_fs/_fs_appendFile.ts | 3 --- ext/node/polyfills/_util/std_asserts.ts | 2 -- ext/node/polyfills/_util/std_fmt_colors.ts | 1 - ext/node/polyfills/internal/util/types.ts | 3 --- ext/node/polyfills/internal_binding/connection_wrap.ts | 3 --- tools/util.js | 4 ++-- 6 files changed, 2 insertions(+), 14 deletions(-) diff --git a/ext/node/polyfills/_fs/_fs_appendFile.ts b/ext/node/polyfills/_fs/_fs_appendFile.ts index b7c63e2706..7077898623 100644 --- a/ext/node/polyfills/_fs/_fs_appendFile.ts +++ b/ext/node/polyfills/_fs/_fs_appendFile.ts @@ -1,8 +1,5 @@ // Copyright 2018-2024 the Deno authors. All rights reserved. MIT license. -// TODO(petamoriken): enable prefer-primordials for node polyfills -// deno-lint-ignore-file prefer-primordials - import { CallbackWithError, isFd, diff --git a/ext/node/polyfills/_util/std_asserts.ts b/ext/node/polyfills/_util/std_asserts.ts index ae23dc08fa..f259042518 100644 --- a/ext/node/polyfills/_util/std_asserts.ts +++ b/ext/node/polyfills/_util/std_asserts.ts @@ -340,7 +340,6 @@ export function assertNotStrictEquals( * then throw. */ export function assertMatch( actual: string, - // deno-lint-ignore prefer-primordials expected: RegExp, msg?: string, ) { @@ -356,7 +355,6 @@ export function assertMatch( * then throw. */ export function assertNotMatch( actual: string, - // deno-lint-ignore prefer-primordials expected: RegExp, msg?: string, ) { diff --git a/ext/node/polyfills/_util/std_fmt_colors.ts b/ext/node/polyfills/_util/std_fmt_colors.ts index 4a3cad1ecb..5072b298ee 100644 --- a/ext/node/polyfills/_util/std_fmt_colors.ts +++ b/ext/node/polyfills/_util/std_fmt_colors.ts @@ -18,7 +18,6 @@ const noColor = false; interface Code { open: string; close: string; - // deno-lint-ignore prefer-primordials regexp: RegExp; } diff --git a/ext/node/polyfills/internal/util/types.ts b/ext/node/polyfills/internal/util/types.ts index 58b1b1045e..30a25e2e5e 100644 --- a/ext/node/polyfills/internal/util/types.ts +++ b/ext/node/polyfills/internal/util/types.ts @@ -21,9 +21,6 @@ // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE // USE OR OTHER DEALINGS IN THE SOFTWARE. -// TODO(petamoriken): enable prefer-primordials for node polyfills -// deno-lint-ignore-file prefer-primordials - import { primordials } from "ext:core/mod.js"; import * as bindingTypes from "ext:deno_node/internal_binding/types.ts"; export { diff --git a/ext/node/polyfills/internal_binding/connection_wrap.ts b/ext/node/polyfills/internal_binding/connection_wrap.ts index 32f08887f2..ef07025e29 100644 --- a/ext/node/polyfills/internal_binding/connection_wrap.ts +++ b/ext/node/polyfills/internal_binding/connection_wrap.ts @@ -24,9 +24,6 @@ // - https://github.com/nodejs/node/blob/master/src/connection_wrap.cc // - https://github.com/nodejs/node/blob/master/src/connection_wrap.h -// TODO(petamoriken): enable prefer-primordials for node polyfills -// deno-lint-ignore-file prefer-primordials - import { LibuvStreamWrap } from "ext:deno_node/internal_binding/stream_wrap.ts"; import { AsyncWrap, diff --git a/tools/util.js b/tools/util.js index e123b828be..92d8da9676 100644 --- a/tools/util.js +++ b/tools/util.js @@ -14,7 +14,7 @@ export { delay } from "../test_util/std/async/delay.ts"; // [toolName] --version output const versions = { - "dlint": "dlint 0.51.0", + "dlint": "dlint 0.52.2", }; const compressed = new Set(["ld64.lld", "rcodesign"]); @@ -175,7 +175,7 @@ export function getPrebuiltToolPath(toolName) { return join(PREBUILT_TOOL_DIR, toolName + executableSuffix); } -const commitId = "c249f61eaed67db26c2934b195dc51e3ab91ae03"; +const commitId = "5f2097d8247c7fbe30ba227f894d70ae5c1524c7"; const downloadUrl = `https://raw.githubusercontent.com/denoland/deno_third_party/${commitId}/prebuilt/${platformDirName}`;