foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-25 15:29:32 -05:00
Code Issues Packages 1 Wiki Activity

chore: Fix typo in no-pending-ops error message (#12948)

Browse source
This commit is contained in:
KnorpelSenf 2021-12-01 15:22:11 +01:00 committed by GitHub
parent 7ef76c1dc3
commit 4c36fa1fdf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cli/tests/testdata/test/unresolved_promise.out vendored
View file

@ -2,4 +2,4 @@ Check [WILDCARD]/test/unresolved_promise.ts
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out ([WILDCARD]) test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out ([WILDCARD])
error: Module evaluation is still pending but there are no pending ops or dynamic imports. This situation is often caused by unresolved promise. error: Module evaluation is still pending but there are no pending ops or dynamic imports. This situation is often caused by unresolved promises.

2
cli/tests/testdata/top_level_await_circular.out vendored
View file

@ -4,6 +4,6 @@ timeout loop 2
timeout loop 3 timeout loop 3
timeout loop 4 timeout loop 4
timeout loop 5 timeout loop 5
error: Dynamically imported module evaluation is still pending but there are no pending ops. This situation is often caused by unresolved promise. error: Dynamically imported module evaluation is still pending but there are no pending ops. This situation is often caused by unresolved promises.
Pending dynamic modules: Pending dynamic modules:
- [WILDCARD]/tla3/b.js - [WILDCARD]/tla3/b.js

2
cli/tests/testdata/top_level_await_unresolved.out vendored
View file

@ -1 +1 @@
error: Module evaluation is still pending but there are no pending ops or dynamic imports. This situation is often caused by unresolved promise. error: Module evaluation is still pending but there are no pending ops or dynamic imports. This situation is often caused by unresolved promises.

4
core/runtime.rs
View file

@ -841,7 +841,7 @@ impl JsRuntime {
{ {
// pass, will be polled again // pass, will be polled again
} else { } else {
let msg = "Module evaluation is still pending but there are no pending ops or dynamic imports. This situation is often caused by unresolved promise."; let msg = "Module evaluation is still pending but there are no pending ops or dynamic imports. This situation is often caused by unresolved promises.";
return Poll::Ready(Err(generic_error(msg))); return Poll::Ready(Err(generic_error(msg)));
} }
} }
@ -854,7 +854,7 @@ impl JsRuntime {
{ {
// pass, will be polled again // pass, will be polled again
} else if state.dyn_module_evaluate_idle_counter >= 1 { } else if state.dyn_module_evaluate_idle_counter >= 1 {
let mut msg = "Dynamically imported module evaluation is still pending but there are no pending ops. This situation is often caused by unresolved promise. let mut msg = "Dynamically imported module evaluation is still pending but there are no pending ops. This situation is often caused by unresolved promises.
Pending dynamic modules:\n".to_string(); Pending dynamic modules:\n".to_string();
for pending_evaluate in &state.pending_dyn_mod_evaluate { for pending_evaluate in &state.pending_dyn_mod_evaluate {
let module_info = module_map let module_info = module_map