1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-21 15:04:11 -05:00

BREAKING(io): remove Deno.write[Sync]() (#25408)

Towards #22079

Signed-off-by: Asher Gomez <ashersaupingomez@gmail.com>
This commit is contained in:
Asher Gomez 2024-09-04 18:57:34 +10:00 committed by GitHub
parent 7e11dbb3ac
commit 4c3b17b547
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 0 additions and 75 deletions

View file

@ -1984,57 +1984,6 @@ declare namespace Deno {
*/ */
export function readSync(rid: number, buffer: Uint8Array): number | null; export function readSync(rid: number, buffer: Uint8Array): number | null;
/** Write to the resource ID (`rid`) the contents of the array buffer (`data`).
*
* Resolves to the number of bytes written. This function is one of the lowest
* level APIs and most users should not work with this directly, but rather
* use {@linkcode WritableStream}, {@linkcode ReadableStream.from} and
* {@linkcode ReadableStream.pipeTo}.
*
* **It is not guaranteed that the full buffer will be written in a single
* call.**
*
* ```ts
* const encoder = new TextEncoder();
* const data = encoder.encode("Hello world");
* using file = await Deno.open("/foo/bar.txt", { write: true });
* const bytesWritten = await Deno.write(file.rid, data); // 11
* ```
*
* @deprecated This will be removed in Deno 2.0. See the
* {@link https://docs.deno.com/runtime/manual/advanced/migrate_deprecations | Deno 1.x to 2.x Migration Guide}
* for migration instructions.
*
* @category I/O
*/
export function write(rid: number, data: Uint8Array): Promise<number>;
/** Synchronously write to the resource ID (`rid`) the contents of the array
* buffer (`data`).
*
* Returns the number of bytes written. This function is one of the lowest
* level APIs and most users should not work with this directly, but rather
* use {@linkcode WritableStream}, {@linkcode ReadableStream.from} and
* {@linkcode ReadableStream.pipeTo}.
*
* **It is not guaranteed that the full buffer will be written in a single
* call.**
*
* ```ts
* const encoder = new TextEncoder();
* const data = encoder.encode("Hello world");
* using file = Deno.openSync("/foo/bar.txt", { write: true });
* const bytesWritten = Deno.writeSync(file.rid, data); // 11
* ```
*
* @deprecated This will be removed in Deno 2.0. See the
* {@link https://docs.deno.com/runtime/manual/advanced/migrate_deprecations | Deno 1.x to 2.x Migration Guide}
* for migration instructions.
*
* @category I/O
*/
export function writeSync(rid: number, data: Uint8Array): number;
/** Seek a resource ID (`rid`) to the given `offset` under mode given by `whence`. /** Seek a resource ID (`rid`) to the given `offset` under mode given by `whence`.
* The call resolves to the new position within the resource (bytes from the start). * The call resolves to the new position within the resource (bytes from the start).
* *

View file

@ -103,22 +103,6 @@ const denoNs = {
); );
return io.readSync(rid, buffer); return io.readSync(rid, buffer);
}, },
write(rid, data) {
internals.warnOnDeprecatedApi(
"Deno.write()",
new Error().stack,
"Use `writer.write()` instead.",
);
return io.write(rid, data);
},
writeSync(rid, data) {
internals.warnOnDeprecatedApi(
"Deno.writeSync()",
new Error().stack,
"Use `writer.writeSync()` instead.",
);
return io.writeSync(rid, data);
},
File: fs.File, File: fs.File,
FsFile: fs.FsFile, FsFile: fs.FsFile,
open: fs.open, open: fs.open,

View file

@ -809,8 +809,6 @@ function bootstrapMainRuntime(runtimeOptions, warmup = false) {
delete Deno.readSync; delete Deno.readSync;
delete Deno.seek; delete Deno.seek;
delete Deno.seekSync; delete Deno.seekSync;
delete Deno.write;
delete Deno.writeSync;
} }
} else { } else {
// Warmup // Warmup
@ -978,8 +976,6 @@ function bootstrapWorkerRuntime(
delete Deno.readSync; delete Deno.readSync;
delete Deno.seek; delete Deno.seek;
delete Deno.seekSync; delete Deno.seekSync;
delete Deno.write;
delete Deno.writeSync;
} }
} else { } else {
// Warmup // Warmup

View file

@ -11,8 +11,6 @@ console.log("Deno.read is", Deno.read);
console.log("Deno.readSync is", Deno.readSync); console.log("Deno.readSync is", Deno.readSync);
console.log("Deno.seek is", Deno.seek); console.log("Deno.seek is", Deno.seek);
console.log("Deno.seekSync is", Deno.seekSync); console.log("Deno.seekSync is", Deno.seekSync);
console.log("Deno.write is", Deno.write);
console.log("Deno.writeSync is", Deno.writeSync);
// TCP // TCP
// Since these tests may run in parallel, ensure this port is unique to this file // Since these tests may run in parallel, ensure this port is unique to this file

View file

@ -8,8 +8,6 @@ Deno.read is undefined
Deno.readSync is undefined Deno.readSync is undefined
Deno.seek is undefined Deno.seek is undefined
Deno.seekSync is undefined Deno.seekSync is undefined
Deno.write is undefined
Deno.writeSync is undefined
Deno.Listener.prototype.rid is undefined Deno.Listener.prototype.rid is undefined
Deno.Conn.prototype.rid is undefined Deno.Conn.prototype.rid is undefined
Deno.UnixConn.prototype.rid is undefined Deno.UnixConn.prototype.rid is undefined