foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-28 16:20:57 -05:00
Code Issues Packages 1 Wiki Activity

fix(doc): Make private types which show up in the rustdocs public (#13230)

Browse source 
`CrossIsolateStore`, `ExtensionBuilder` and `InMemoryChannelResource`
are private types which are referred to by other public APIs, and so
don't show up as links in the rustdoc. This is especially confusing for
`ExtensionBuilder`, since there is nothing in the docs that explains how
to build an extension.

Exposing these three types doesn't add any new capabilities:
`ExtensionBuilder` can be created from `Extension::builder()`,
`SharedArrayBufferStore` and `CompiledWasmModuleStore` already enable
doing anything that `CrossIsolateStore` can do by itself, and
`InMemoryChannelResource` isn't constructable.
This commit is contained in:
Andreu Botella 2021-12-30 02:05:26 +01:00 committed by Bartek Iwańczuk
parent 0537d8255d
commit 4e1fd69760
No known key found for this signature in database
GPG key ID: 0C6BCDDC3B3AD750
2 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
core/lib.rs
View file

@ -88,6 +88,7 @@ pub use crate::resources::Resource;
pub use crate::resources::ResourceId; pub use crate::resources::ResourceId;
pub use crate::resources::ResourceTable; pub use crate::resources::ResourceTable;
pub use crate::runtime::CompiledWasmModuleStore; pub use crate::runtime::CompiledWasmModuleStore;
pub use crate::runtime::CrossIsolateStore;
pub use crate::runtime::GetErrorClassFn; pub use crate::runtime::GetErrorClassFn;
pub use crate::runtime::JsErrorCreateFn; pub use crate::runtime::JsErrorCreateFn;
pub use crate::runtime::JsRuntime; pub use crate::runtime::JsRuntime;
@ -96,6 +97,7 @@ pub use crate::runtime::SharedArrayBufferStore;
pub use crate::runtime::Snapshot; pub use crate::runtime::Snapshot;
// pub use crate::runtime_modules::include_js_files!; // pub use crate::runtime_modules::include_js_files!;
pub use crate::extensions::Extension; pub use crate::extensions::Extension;
pub use crate::extensions::ExtensionBuilder;
pub use crate::extensions::OpMiddlewareFn; pub use crate::extensions::OpMiddlewareFn;
pub use crate::extensions::OpPair; pub use crate::extensions::OpPair;

1
ext/broadcast_channel/lib.rs
View file

@ -3,6 +3,7 @@
mod in_memory_broadcast_channel; mod in_memory_broadcast_channel;
pub use in_memory_broadcast_channel::InMemoryBroadcastChannel; pub use in_memory_broadcast_channel::InMemoryBroadcastChannel;
pub use in_memory_broadcast_channel::InMemoryBroadcastChannelResource;
use async_trait::async_trait; use async_trait::async_trait;
use deno_core::error::AnyError; use deno_core::error::AnyError;