foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-28 16:20:57 -05:00
Code Issues Packages 1 Wiki Activity

fix(jsr): panic when importing jsr package with deps via https (#23728)

Browse source 
Closes #23644
This commit is contained in:
David Sherret 2024-05-07 17:53:17 -04:00 committed by GitHub
parent 25fcfe5d79
commit 5379bb0289
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 23 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Cargo.lock generated
View file

@ -1483,9 +1483,9 @@ dependencies = [
[[package]] [[package]]
name = "deno_graph" name = "deno_graph"
version = "0.74.4" version = "0.74.5"
source = "registry+https://github.com/rust-lang/crates.io-index" source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "d70d7b300e5a4863d817db6fdcd914b57ff5165b481b4288437fe63d48757765" checksum = "9b7078d584a4ff53349ec8f7909826dffe2a0c2ccb61b9b6549ea38d996d5a61"
dependencies = [ dependencies = [
"anyhow", "anyhow",
"async-trait", "async-trait",

2
cli/Cargo.toml
View file

@ -69,7 +69,7 @@ deno_config = "=0.16.3"
deno_core = { workspace = true, features = ["include_js_files_for_snapshotting"] } deno_core = { workspace = true, features = ["include_js_files_for_snapshotting"] }
deno_doc = { version = "=0.129.0", features = ["html", "syntect"] } deno_doc = { version = "=0.129.0", features = ["html", "syntect"] }
deno_emit = "=0.40.2" deno_emit = "=0.40.2"
deno_graph = { version = "=0.74.4", features = ["tokio_executor"] } deno_graph = { version = "=0.74.5", features = ["tokio_executor"] }
deno_lint = { version = "=0.58.4", features = ["docs"] } deno_lint = { version = "=0.58.4", features = ["docs"] }
deno_lockfile.workspace = true deno_lockfile.workspace = true
deno_npm = "=0.18.0" deno_npm = "=0.18.0"

4
tests/specs/jsr/import_jsr_via_https/main.check.out
View file

@ -1,3 +1,3 @@
error: Failed resolving types. Importing JSR packages via HTTPS specifiers for type checking is not supported for performance reasons. If you would like types, import via a `jsr:` specifier instead or else use a non-statically analyzable dynamic import. error: Failed resolving types. Importing JSR packages via HTTPS specifiers for type checking is not supported for performance reasons. If you would like types, import via a `jsr:` specifier instead or else use a non-statically analyzable dynamic import.
Importing: http://127.0.0.1:4250/@denotest/add/1.0.0/mod.ts Importing: http://127.0.0.1:4250/@denotest/deps/1.0.0/mod.ts
at file:///[WILDLINE]/import_jsr_via_https/main.ts:1:21 at file:///[WILDLINE]/import_jsr_via_https/main.ts:1:18

13
tests/specs/jsr/import_jsr_via_https/main.info.out
View file

@ -1,10 +1,9 @@
local: [WILDLINE] [WILDCARD]
emit: [WILDLINE]
type: TypeScript
dependencies: [WILDLINE]
size: [WILDLINE]
file:///[WILDLINE]/main.ts ([WILDLINE]) file:///[WILDLINE]/main.ts ([WILDLINE])
├── http://127.0.0.1:4250/@denotest/add/1.0.0/mod.ts ([WILDLINE]) ├─┬ http://127.0.0.1:4250/@denotest/deps/1.0.0/mod.ts ([WILDLINE])
│ ├── http://127.0.0.1:4250/@denotest/module-graph/1.4.0/other.ts ([WILDLINE])
│ └─┬ http://127.0.0.1:4250/@denotest/no-module-graph/0.1.1/mod.ts ([WILDLINE])
│ └── http://127.0.0.1:4250/@denotest/no-module-graph/0.1.1/TestClass.ts ([WILDLINE])
└── Importing JSR packages via HTTPS specifiers for type checking is not supported for performance reasons. If you would like types, import via a `jsr:` specifier instead or else use a non-statically analyzable dynamic import. └── Importing JSR packages via HTTPS specifiers for type checking is not supported for performance reasons. If you would like types, import via a `jsr:` specifier instead or else use a non-statically analyzable dynamic import.
Importing: http://127.0.0.1:4250/@denotest/add/1.0.0/mod.ts (resolve error) Importing: http://127.0.0.1:4250/@denotest/deps/1.0.0/mod.ts (resolve error)

13
tests/specs/jsr/import_jsr_via_https/main.out
View file

@ -1,3 +1,10 @@
Download http://127.0.0.1:4250/@denotest/add/1.0.0_meta.json Download http://127.0.0.1:4250/@denotest/deps/1.0.0_meta.json
Download http://127.0.0.1:4250/@denotest/add/1.0.0/mod.ts Download http://127.0.0.1:4250/@denotest/deps/1.0.0/mod.ts
3 Download http://127.0.0.1:4250/@denotest/module-graph/meta.json
Download http://127.0.0.1:4250/@denotest/no-module-graph/meta.json
Download http://127.0.0.1:4250/@denotest/module-graph/1.4.0_meta.json
Download http://127.0.0.1:4250/@denotest/no-module-graph/0.1.1_meta.json
Download http://127.0.0.1:4250/@denotest/no-module-graph/0.1.1/mod.ts
Download http://127.0.0.1:4250/@denotest/no-module-graph/0.1.1/TestClass.ts
Download http://127.0.0.1:4250/@denotest/module-graph/1.4.0/other.ts
0.1.1

4
tests/specs/jsr/import_jsr_via_https/main.ts
View file

@ -1,3 +1,3 @@
import { add } from "http://127.0.0.1:4250/@denotest/add/1.0.0/mod.ts"; import deps from "http://127.0.0.1:4250/@denotest/deps/1.0.0/mod.ts";
console.log(add(1, 2)); console.log(deps.version);