From 539e5032d372679869dcee4e2e63f2116288b435 Mon Sep 17 00:00:00 2001 From: Marvin Hagemeister Date: Mon, 28 Aug 2023 17:07:22 +0200 Subject: [PATCH] fix: unexpected lsp function arg comma completion (#20311) --- cli/lsp/capabilities.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cli/lsp/capabilities.rs b/cli/lsp/capabilities.rs index 355f7b6c51..e814daf0b6 100644 --- a/cli/lsp/capabilities.rs +++ b/cli/lsp/capabilities.rs @@ -53,9 +53,10 @@ pub fn server_capabilities( )), hover_provider: Some(HoverProviderCapability::Simple(true)), completion_provider: Some(CompletionOptions { + // Don't include "," here as it leads to confusing completion + // behavior with function arguments. See https://github.com/denoland/deno/issues/20160 all_commit_characters: Some(vec![ ".".to_string(), - ",".to_string(), ";".to_string(), "(".to_string(), ]),