foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-22 15:06:54 -05:00
Code Issues Packages 1 Wiki Activity

fix(ext/crypto): throw DataError for invalid EC key import (#25181)

Browse source 
Fixes https://github.com/denoland/deno/issues/20931
This commit is contained in:
Divy Srivastava 2024-08-23 09:36:40 -07:00 committed by Luca Casonato
parent 37fa0e0f48
commit 58edc634f9
No known key found for this signature in database
GPG key ID: 01A83EB62563811F
2 changed files with 23 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
ext/crypto/import_key.rs
View file

@ -689,7 +689,8 @@ fn import_key_ec(
let rng = ring::rand::SystemRandom::new(); let rng = ring::rand::SystemRandom::new();
// deserialize pkcs8 using ring crate, to VALIDATE public key // deserialize pkcs8 using ring crate, to VALIDATE public key
let _private_key = EcdsaKeyPair::from_pkcs8(signing_alg, &data, &rng)?; let _private_key = EcdsaKeyPair::from_pkcs8(signing_alg, &data, &rng)
.map_err(|_| data_error("invalid key"))?;
// 11. // 11.
if named_curve != pk_named_curve { if named_curve != pk_named_curve {

21
tests/unit/webcrypto_test.ts
View file

@ -2045,3 +2045,24 @@ Deno.test(async function p521Generate() {
assert(key.privateKey instanceof CryptoKey); assert(key.privateKey instanceof CryptoKey);
assert(key.publicKey instanceof CryptoKey); assert(key.publicKey instanceof CryptoKey);
}); });
Deno.test(async function invalidEcPointDataError() {
await assertRejects(async () => {
await crypto.subtle
.importKey(
"pkcs8",
// deno-fmt-ignore
new Uint8Array([
48, 102, 2, 1, 0, 48, 19, 6, 7, 42, 134, 72, 206, 61, 2, 1, 6, 8, 42, 134,
72, 206, 61, 3, 1, 7, 4, 76, 48, 74, 2, 1, 1, 4, 32, 255, 255, 255, 255,
0, 0, 0, 0, 255, 255, 255, 255, 255, 255, 255, 255, 188, 230, 250, 173,
167, 23, 158, 132, 243, 185, 202, 194, 252, 99, 37, 81, 161, 35, 3, 33, 0,
0, 255, 255, 255, 0, 0, 0, 0, 255, 255, 255, 255, 255, 255, 255, 255, 188,
230, 250, 173, 167, 23, 158, 132, 243, 185, 202, 194, 252, 99, 37, 81,
]),
{ name: "ECDSA", namedCurve: "P-256" },
true,
["sign"],
);
}, DOMException);
});