foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-21 15:04:11 -05:00
Code Issues Packages 1 Wiki Activity

chore: disable failing node compat test (#19811)

Browse source
This commit is contained in:
Bartek Iwańczuk 2023-07-12 21:30:37 +02:00 committed by GitHub
parent 80331d1fe5
commit 5bc24c8a20
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 21 additions and 39 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

60
cli/tests/node_compat/test/internet/test-dns.js
View file

@ -430,45 +430,27 @@ TEST(async function test_resolveCaa(done) {
checkWrap(req);
});
TEST(function test_resolveCaa_failure(done) {
dnsPromises.resolveTxt(addresses.NOT_FOUND)
.then(common.mustNotCall())
.catch(common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOTFOUND');
}));
const req = dns.resolveCaa(addresses.NOT_FOUND, function(err, result) {
assert.ok(err instanceof Error);
assert.strictEqual(err.code, 'ENOTFOUND');
assert.strictEqual(result, undefined);
done();
});
checkWrap(req);
});
TEST(async function test_resolveCname(done) {
function validateResult(result) {
assert.ok(result.length > 0);
for (const item of result) {
assert.ok(item);
assert.strictEqual(typeof item, 'string');
}
}
validateResult(await dnsPromises.resolveCname(addresses.CNAME_HOST));
const req = dns.resolveCname(addresses.CNAME_HOST, function(err, names) {
assert.ifError(err);
validateResult(names);
done();
});
checkWrap(req);
});
// NOTE(bartlomieju): this test started failing around July 11th, 2023.
// TEST(async function test_resolveCname(done) {
// function validateResult(result) {
// assert.ok(result.length > 0);
//
// for (const item of result) {
// assert.ok(item);
// assert.strictEqual(typeof item, 'string');
// }
// }
//
// validateResult(await dnsPromises.resolveCname(addresses.CNAME_HOST));
//
// const req = dns.resolveCname(addresses.CNAME_HOST, function(err, names) {
// assert.ifError(err);
// validateResult(names);
// done();
// });
//
// checkWrap(req);
// });
TEST(function test_resolveCname_failure(done) {
dnsPromises.resolveCname(addresses.NOT_FOUND)