foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-01-18 03:44:05 -05:00
Code Issues Packages 1 Wiki Activity

chore(cli): Don't assume deno is in path for spawn_kill_permissions (#19198)

Browse source 
We don't need to use the `deno` command here to test kill permissions
and it's awkward to get right without passing `-A`. `cat` works, but for
platforms other than windows. This test should have plenty of coverage
on other platforms.
This commit is contained in:
Matt Mastracci 2023-05-22 09:54:58 -06:00 • committed by GitHub
parent 19f1823e44
commit 5c349039b8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
cli/tests/integration/run_tests.rs
View file

@ -3434,8 +3434,9 @@ itest!(test_and_bench_are_noops_in_run {
output_str: Some(""), output_str: Some(""),
}); });
#[cfg(not(target_os = "windows"))]
itest!(spawn_kill_permissions { itest!(spawn_kill_permissions {
args: "run --quiet --unstable --allow-run=deno spawn_kill_permissions.ts", args: "run --quiet --unstable --allow-run=cat spawn_kill_permissions.ts",
output_str: Some(""), output_str: Some(""),
}); });

4
cli/tests/testdata/spawn_kill_permissions.ts vendored
View file

@ -1,5 +1,5 @@
const child = new Deno.Command("deno", { const child = new Deno.Command("cat", {
args: ["eval", "await new Promise(r => setTimeout(r, 2000))"], args: ["-"],
stdout: "null", stdout: "null",
stderr: "null", stderr: "null",
}).spawn(); }).spawn();