foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-01-08 15:19:40 -05:00
Code Issues Packages 1 Wiki Activity

Revert "Support CheckJS"

Browse source 
Broken in master.

This reverts commit dd230d520b.
This commit is contained in:
Ryan Dahl 2018-10-23 09:54:52 -04:00
parent dd230d520b
commit 5cf37c2f20
5 changed files with 0 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
js/compiler.ts
View file

@ -152,7 +152,6 @@ export class DenoCompiler
// arguments // arguments
private readonly _options: Readonly<ts.CompilerOptions> = { private readonly _options: Readonly<ts.CompilerOptions> = {
allowJs: true, allowJs: true,
checkJs: true,
module: ts.ModuleKind.AMD, module: ts.ModuleKind.AMD,
outDir: "$deno$", outDir: "$deno$",
// TODO https://github.com/denoland/deno/issues/23 // TODO https://github.com/denoland/deno/issues/23

6
tests/error_008_checkjs.js
View file

@ -1,6 +0,0 @@
// console.log intentionally misspelled to trigger a type error
consol.log("hello world!");
// the following error should be ignored and not output to the console
// @ts-ignore
const foo = new Foo();

10
tests/error_008_checkjs.js.out
View file

@ -1,10 +0,0 @@
[WILDCARD]/tests/error_008_checkjs.jsILDCARD] - error TS2552: Cannot find name 'consol'. Did you mean 'console'?
ILDCARD] consol.log("hello world!");
[WILDCARD]~~~~~~
$asset$/lib.deno_runtime.d.tsILDCARD]
[WILDCARD]declare const console: console_.Console;
[WILDCARD]~~~~~~~
[WILDCARD]'console' is declared here.

2
tsconfig.json
View file

@ -1,9 +1,7 @@
{ {
"compilerOptions": { "compilerOptions": {
"allowJs": true,
"allowUnreachableCode": false, "allowUnreachableCode": false,
"baseUrl": ".", "baseUrl": ".",
"checkJs": true,
"module": "esnext", "module": "esnext",
"moduleResolution": "node", "moduleResolution": "node",
"noImplicitReturns": true, "noImplicitReturns": true,

4
website/app.js
View file

@ -154,12 +154,10 @@ function gen2(
}; };
} }
// @ts-ignore
c3.generate({ c3.generate({
bindto: id, bindto: id,
size: { size: {
height: 300, height: 300,
// @ts-ignore
width: window.chartWidth || 375 // TODO: do not use global variable width: window.chartWidth || 375 // TODO: do not use global variable
}, },
data: { data: {
@ -203,7 +201,6 @@ export async function drawChartsFromBenchmarkData(dataUrl) {
const sha1ShortList = sha1List.map(sha1 => sha1.substring(0, 6)); const sha1ShortList = sha1List.map(sha1 => sha1.substring(0, 6));
const viewCommitOnClick = _sha1List => d => { const viewCommitOnClick = _sha1List => d => {
// @ts-ignore
window.open( window.open(
`https://github.com/denoland/deno/commit/${_sha1List[d["index"]]}` `https://github.com/denoland/deno/commit/${_sha1List[d["index"]]}`
); );
@ -233,7 +230,6 @@ export async function drawChartsFromBenchmarkData(dataUrl) {
*/ */
export async function drawChartsFromTravisData() { export async function drawChartsFromTravisData() {
const viewPullRequestOnClick = _prNumberList => d => { const viewPullRequestOnClick = _prNumberList => d => {
// @ts-ignore
window.open( window.open(
`https://github.com/denoland/deno/pull/${_prNumberList[d["index"]]}` `https://github.com/denoland/deno/pull/${_prNumberList[d["index"]]}`
); );