foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-01-11 08:33:43 -05:00
Code Issues Packages 1 Wiki Activity

refactor: make 'rid' properties non-enumerable (#22137)

Browse source 
Now these props will not show up when inspecting objects in console.
This commit is contained in:
Bartek Iwańczuk 2024-01-26 23:19:00 +01:00 committed by GitHub
parent 942fb5e038
commit 6109717c4a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 31 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
ext/fs/30_fs.js
View file

@ -83,6 +83,7 @@ const {
Function,
MathTrunc,
ObjectEntries,
ObjectDefineProperty,
ObjectPrototypeIsPrototypeOf,
ObjectValues,
StringPrototypeSlice,
@ -656,14 +657,16 @@ function create(path) {
}
class FsFile {
[internalRidSymbol] = 0;
#rid = 0;
#readable;
#writable;
constructor(rid, symbol) {
this[internalRidSymbol] = rid;
ObjectDefineProperty(this, internalRidSymbol, {
enumerable: false,
value: rid,
});
this.#rid = rid;
if (!symbol || symbol !== SymbolFor("Deno.internal.FsFile")) {
internals.warnOnDeprecatedApi(

25
ext/net/01_net.js
View file

@ -34,6 +34,7 @@ const {
Error,
Number,
ObjectPrototypeIsPrototypeOf,
ObjectDefineProperty,
PromiseResolve,
SafeSet,
SetPrototypeAdd,
@ -91,7 +92,6 @@ async function resolveDns(query, recordType, options) {
}
class Conn {
[internalRidSymbol] = 0;
#rid = 0;
#remoteAddr = null;
#localAddr = null;
@ -102,7 +102,10 @@ class Conn {
#writable;
constructor(rid, remoteAddr, localAddr) {
this[internalRidSymbol] = rid;
ObjectDefineProperty(this, internalRidSymbol, {
enumerable: false,
value: rid,
});
this.#rid = rid;
this.#remoteAddr = remoteAddr;
this.#localAddr = localAddr;
@ -201,12 +204,14 @@ class Conn {
}
class TcpConn extends Conn {
[internalRidSymbol] = 0;
#rid = 0;
constructor(rid, remoteAddr, localAddr) {
super(rid, remoteAddr, localAddr);
this[internalRidSymbol] = rid;
ObjectDefineProperty(this, internalRidSymbol, {
enumerable: false,
value: rid,
});
this.#rid = rid;
}
@ -229,12 +234,14 @@ class TcpConn extends Conn {
}
class UnixConn extends Conn {
[internalRidSymbol] = 0;
#rid = 0;
constructor(rid, remoteAddr, localAddr) {
super(rid, remoteAddr, localAddr);
this[internalRidSymbol] = rid;
ObjectDefineProperty(this, internalRidSymbol, {
enumerable: false,
value: rid,
});
this.#rid = rid;
}
@ -249,14 +256,16 @@ class UnixConn extends Conn {
}
class Listener {
[internalRidSymbol] = 0;
#rid = 0;
#addr = null;
#unref = false;
#promise = null;
constructor(rid, addr) {
this[internalRidSymbol] = rid;
ObjectDefineProperty(this, internalRidSymbol, {
enumerable: false,
value: rid,
});
this.#rid = rid;
this.#addr = addr;
}

13
ext/net/02_tls.js
View file

@ -11,6 +11,7 @@ const {
} = core.ensureFastOps();
const {
Number,
ObjectDefineProperty,
TypeError,
} = primordials;
@ -25,12 +26,14 @@ function opTlsHandshake(rid) {
}
class TlsConn extends Conn {
[internalRidSymbol] = 0;
#rid = 0;
constructor(rid, remoteAddr, localAddr) {
super(rid, remoteAddr, localAddr);
this[internalRidSymbol] = rid;
ObjectDefineProperty(this, internalRidSymbol, {
enumerable: false,
value: rid,
});
this.#rid = rid;
}
@ -78,12 +81,14 @@ async function connectTls({
}
class TlsListener extends Listener {
[internalRidSymbol] = 0;
#rid = 0;
constructor(rid, addr) {
super(rid, addr);
this[internalRidSymbol] = rid;
ObjectDefineProperty(this, internalRidSymbol, {
enumerable: false,
value: rid,
});
this.#rid = rid;
}