From 630d0f213d54fe2dcce94b338a87373d64e3f716 Mon Sep 17 00:00:00 2001
From: Vincent LE GOFF <g_n_s@hotmail.fr>
Date: Tue, 26 Mar 2019 13:15:16 +0100
Subject: [PATCH] Fix assertEquals for RegExp & Date (denoland/deno_std#305)

Original: https://github.com/denoland/deno_std/commit/e17364b91fb5360624e9529ed26cb3c6f0ca6a38
---
 datetime/test.ts        | 28 ++++++++++++++--------------
 testing/asserts.ts      | 10 ++++++++++
 testing/asserts_test.ts |  4 ++++
 3 files changed, 28 insertions(+), 14 deletions(-)

diff --git a/datetime/test.ts b/datetime/test.ts
index 1a5ad22e45..dcbc166a5b 100644
--- a/datetime/test.ts
+++ b/datetime/test.ts
@@ -5,28 +5,28 @@ import * as datetime from "./mod.ts";
 
 test(function parseDateTime() {
   assertEquals(
-    datetime.parseDateTime("01-03-2019 16:34", "mm-dd-yyyy hh:mm"),
-    new Date(2019, 1, 3, 16, 34)
+    datetime.parseDateTime("01-03-2019 16:30", "mm-dd-yyyy hh:mm"),
+    new Date(2019, 0, 3, 16, 30)
   );
   assertEquals(
-    datetime.parseDateTime("03-01-2019 16:34", "dd-mm-yyyy hh:mm"),
-    new Date(2019, 1, 3, 16, 34)
+    datetime.parseDateTime("03-01-2019 16:31", "dd-mm-yyyy hh:mm"),
+    new Date(2019, 0, 3, 16, 31)
   );
   assertEquals(
-    datetime.parseDateTime("2019-01-03 16:34", "yyyy-mm-dd hh:mm"),
-    new Date(2019, 1, 3, 16, 34)
+    datetime.parseDateTime("2019-01-03 16:32", "yyyy-mm-dd hh:mm"),
+    new Date(2019, 0, 3, 16, 32)
   );
   assertEquals(
-    datetime.parseDateTime("16:34 01-03-2019", "hh:mm mm-dd-yyyy"),
-    new Date(2019, 1, 3, 16, 34)
+    datetime.parseDateTime("16:33 01-03-2019", "hh:mm mm-dd-yyyy"),
+    new Date(2019, 0, 3, 16, 33)
   );
   assertEquals(
     datetime.parseDateTime("16:34 03-01-2019", "hh:mm dd-mm-yyyy"),
-    new Date(2019, 1, 3, 16, 34)
+    new Date(2019, 0, 3, 16, 34)
   );
   assertEquals(
-    datetime.parseDateTime("16:34 2019-01-03", "hh:mm yyyy-mm-dd"),
-    new Date(2019, 1, 3, 16, 34)
+    datetime.parseDateTime("16:35 2019-01-03", "hh:mm yyyy-mm-dd"),
+    new Date(2019, 0, 3, 16, 35)
   );
 });
 
@@ -43,15 +43,15 @@ test(function invalidParseDateTimeFormatThrows() {
 test(function parseDate() {
   assertEquals(
     datetime.parseDate("01-03-2019", "mm-dd-yyyy"),
-    new Date(2019, 1, 3)
+    new Date(2019, 0, 3)
   );
   assertEquals(
     datetime.parseDate("03-01-2019", "dd-mm-yyyy"),
-    new Date(2019, 1, 3)
+    new Date(2019, 0, 3)
   );
   assertEquals(
     datetime.parseDate("2019-01-03", "yyyy-mm-dd"),
-    new Date(2019, 1, 3)
+    new Date(2019, 0, 3)
   );
 });
 
diff --git a/testing/asserts.ts b/testing/asserts.ts
index 6d975bbb59..eb5e119692 100644
--- a/testing/asserts.ts
+++ b/testing/asserts.ts
@@ -16,6 +16,16 @@ export class AssertionError extends Error {
 export function equal(c: unknown, d: unknown): boolean {
   const seen = new Map();
   return (function compare(a: unknown, b: unknown) {
+    // Have to render RegExp & Date for string comparison
+    // unless it's mistreated as object
+    if (
+      a &&
+      b &&
+      ((a instanceof RegExp && b instanceof RegExp) ||
+        (a instanceof Date && b instanceof Date))
+    ) {
+      return String(a) === String(b);
+    }
     if (Object.is(a, b)) {
       return true;
     }
diff --git a/testing/asserts_test.ts b/testing/asserts_test.ts
index 6f82d41697..87e0335ac5 100644
--- a/testing/asserts_test.ts
+++ b/testing/asserts_test.ts
@@ -36,6 +36,10 @@ test(function testingEqual() {
       { hello: "world", hi: { there: "everyone else" } }
     )
   );
+  assert(equal(/deno/, /deno/));
+  assert(!equal(/deno/, /node/));
+  assert(equal(new Date(2019, 0, 3), new Date(2019, 0, 3)));
+  assert(!equal(new Date(2019, 0, 3), new Date(2019, 1, 3)));
 });
 
 test(function testingNotEquals() {