foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-25 15:29:32 -05:00
Code Issues Packages 1 Wiki Activity

fix(node): polyfill process.title (#20044)

Browse source 
Closes https://github.com/denoland/deno/issues/19777
This commit is contained in:
Bartek Iwańczuk 2023-08-04 14:31:13 +02:00 committed by GitHub
parent 8d8a89ceea
commit 6405b5f454
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
cli/tests/unit_node/process_test.ts
View file

@ -764,3 +764,13 @@ Deno.test({
assert(typeof process.stdout.isTTY === "boolean");
},
});
Deno.test({
name: "process.title",
fn() {
assertEquals(process.title, "deno");
// Verify that setting the value has no effect.
process.title = "foo";
assertEquals(process.title, "deno");
},
});

10
ext/node/polyfills/process.ts
View file

@ -364,6 +364,16 @@ class Process extends EventEmitter {
return arch;
}
get title() {
return "deno";
}
set title(_value) {
// NOTE(bartlomieju): this is a noop. Node.js doesn't guarantee that the
// process name will be properly set and visible from other tools anyway.
// Might revisit in the future.
}
/**
* https://nodejs.org/api/process.html#process_process_argv
* Read permissions are required in order to get the executable route