foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-01-05 05:49:20 -05:00
Code Issues Packages 1 Wiki Activity

Don't expose ErrWithV8Handle from deno_core

Browse source
This commit is contained in:
Ryan Dahl 2020-09-15 10:24:13 -04:00
parent 28c9d90b4b
commit 68099acbc6
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
cli/errors.rs
View file

@ -11,7 +11,6 @@
use crate::ast::DiagnosticBuffer; use crate::ast::DiagnosticBuffer;
use crate::import_map::ImportMapError; use crate::import_map::ImportMapError;
use deno_core::error::get_custom_error_class;
use deno_core::error::AnyError; use deno_core::error::AnyError;
use deno_core::ModuleResolutionError; use deno_core::ModuleResolutionError;
use rustyline::error::ReadlineError; use rustyline::error::ReadlineError;
@ -171,7 +170,7 @@ fn get_nix_error_class(error: &nix::Error) -> &'static str {
} }
pub(crate) fn get_error_class_name(e: &AnyError) -> &'static str { pub(crate) fn get_error_class_name(e: &AnyError) -> &'static str {
get_custom_error_class(e) deno_core::error::get_custom_error_class(e)
.or_else(|| { .or_else(|| {
e.downcast_ref::<dlopen::Error>() e.downcast_ref::<dlopen::Error>()
.map(get_dlopen_error_class) .map(get_dlopen_error_class)

2
core/error.rs
View file

@ -381,7 +381,7 @@ pub(crate) fn attach_handle_to_error(
// TODO(piscisaureus): rusty_v8 should implement the Error trait on // TODO(piscisaureus): rusty_v8 should implement the Error trait on
// values of type v8::Global<T>. // values of type v8::Global<T>.
pub struct ErrWithV8Handle { pub(crate) struct ErrWithV8Handle {
err: AnyError, err: AnyError,
handle: v8::Global<v8::Value>, handle: v8::Global<v8::Value>,
} }